Merge lp://staging/~thomas-voss/net-cpp/fix-parsing-of-empty-header-values into lp://staging/net-cpp

Proposed by Thomas Voß
Status: Merged
Approved by: Timo Jyrinki
Approved revision: 43
Merged at revision: 41
Proposed branch: lp://staging/~thomas-voss/net-cpp/fix-parsing-of-empty-header-values
Merge into: lp://staging/net-cpp
Diff against target: 160 lines (+74/-29)
3 files modified
debian/libnet-cpp1.symbols (+2/-0)
src/core/net/http/impl/curl/request.h (+41/-29)
tests/http_client_test.cpp (+31/-0)
To merge this branch: bzr merge lp://staging/~thomas-voss/net-cpp/fix-parsing-of-empty-header-values
Reviewer Review Type Date Requested Status
Pete Woods (community) Approve
XiaoGuo, Liu Pending
Ubuntu Phablet Team Pending
Review via email: mp+241677@code.staging.launchpad.net

Commit message

Robustify header line parser against empty values in header lines.
Add test case to verify that empty header value handling is correct.

Description of the change

Robustify header line parser against empty values in header lines.
Add test case to verify that empty header value handling is correct.

To post a comment you must log in.
42. By Thomas Voß

Rely on std::regex to do the actual parsing/matching.

Revision history for this message
Pete Woods (pete-woods) :
review: Approve
43. By Thomas Voß

Update symbols file.

Revision history for this message
Timo Jyrinki (timo-jyrinki) wrote :

Top-approving based on Pete's approval.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches