net-cpp

Merge lp://staging/~thomas-voss/net-cpp/bug-fixing-and-features-landing into lp://staging/net-cpp

  1. bug-fixing-and-features-landing
  2. Merge into trunk
Proposed by Thomas Voß
Status: Merged
Merged at revision: 50
Proposed branch: lp://staging/~thomas-voss/net-cpp/bug-fixing-and-features-landing
Merge into: lp://staging/net-cpp
Prerequisite: lp://staging/~gary-wzl77/net-cpp/bug-fixing-and-features
Diff against target: 431 lines (+163/-59)
11 files modified
debian/changelog (+8/-0)
debian/control (+2/-2)
debian/libnet-cpp2.symbols (+1/-1)
include/core/net/http/request.h (+9/-9)
include/core/net/http/streaming_request.h (+0/-12)
src/core/net/http/impl/curl/client.cpp (+17/-0)
src/core/net/http/impl/curl/easy.cpp (+1/-1)
src/core/net/http/impl/curl/multi.cpp (+5/-0)
src/core/net/http/impl/curl/multi.h (+3/-0)
src/core/net/http/impl/curl/request.h (+23/-27)
tests/http_streaming_client_test.cpp (+94/-7)
To merge this branch: bzr merge lp://staging/~thomas-voss/net-cpp/bug-fixing-and-features-landing
Reviewer Review Type Date Requested Status
Gary.Wang (community) Approve
Ubuntu Phablet Team Pending
Review via email: mp+296140@code.staging.launchpad.net

Commit message

* Enable pause/resume of requests.
* Fix LP:#1570686 and LP:#1570687

Description of the change

* Enable pause/resume of requests.
* Fix LP:#1570686 and LP:#1570687

To post a comment you must log in.
Revision history for this message
Thomas Voß (thomas-voss) wrote :

@Gary: I changed a few minor things when compared to your MP:
  - pause/resume on the easy handle is invoked on the downloading/uploading thread now.
  - fixed the test case to talk to a server that is (hopefully) reachable from within our CI labs.
  - some packaging updates to account for the major version bump.
  - moved speed.{limit, duration} into the Request::Configuration struct, picking reasonable values by default.

Revision history for this message
Gary.Wang (gary-wzl77) wrote :

Thanks tvoss for this MP, it looks good to me.
In this MP, I didn't see pause/resume issue anymore.
I think i should put speed.{limit, duration} into Request::Configuration struct in my MP just as what you do in this MP since we already have this struct there.
I really like the implementation of progress bar, it's quite neat and simple.
Thanks again.

P.S I forget we have sth available in CI labs. :)

review: Approve
lp://staging/~thomas-voss/net-cpp/bug-fixing-and-features-landing updated
55. By Thomas Voß

Make sure that exceptions while pausing/resuming an easy handle are not propagating.
Flush output stream for progress bar.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches