net-cpp

Merge lp://staging/~thomas-voss/net-cpp/add-streaming into lp://staging/net-cpp

add-streaming
Merge into trunk

Proposed by Thomas Voß on 2015-03-23

Status:

Merged

Approved by:

Marcus Tomlinson on 2015-04-07

Approved revision:

Merged at revision:

Proposed branch:

lp://staging/~thomas-voss/net-cpp/add-streaming

Merge into:

lp://staging/net-cpp

Diff against target:

1051 lines (+802/-28)

11 files modified

CMakeLists.txt (+3/-1)
debian/changelog (+6/-0)
debian/libnet-cpp1.symbols (+4/-0)
include/core/net/http/streaming_client.h (+88/-0)
include/core/net/http/streaming_request.h (+60/-0)
src/CMakeLists.txt (+2/-0)
src/core/net/http/impl/curl/client.cpp (+74/-8)
src/core/net/http/impl/curl/client.h (+24/-16)
src/core/net/http/impl/curl/request.h (+17/-3)
tests/CMakeLists.txt (+16/-0)
tests/http_streaming_client_test.cpp (+508/-0)

To merge this branch:

bzr merge lp://staging/~thomas-voss/net-cpp/add-streaming

High

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Marcus Tomlinson (community)		2015-03-23	Approve on 2015-03-25
PS Jenkins bot	continuous-integration		Approve on 2015-03-24
Ubuntu Phablet Team		2015-03-23	Pending
Review via email: mp+253850@code.staging.launchpad.net

Commit message

Add streaming support to net-cpp in an ABI-stable way.

Description of the change

Add streaming support to net-cpp in an ABI-stable way.

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-23:

PASSED: Continuous integration, rev:49
http://jenkins.qa.ubuntu.com/job/net-cpp-ci/6/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-armhf-ci/6
        deb: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-armhf-ci/6/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-i386-ci/6

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/net-cpp-ci/6/rebuild

review: Approve (continuous-integration)

Revision history for this message

Marcus Tomlinson (marcustomlinson) wrote on 2015-03-24:

361 +class Client : public core::net::http::StreamingClient

Just noticing a few overriding methods in this class that don't specify "override" in their declarations. i.e. url_escape, timings, run, stop, get, head, post, and pull.

review: Needs Fixing

Revision history for this message

PS Jenkins bot (ps-jenkins) wrote on 2015-03-24:

PASSED: Continuous integration, rev:50
http://jenkins.qa.ubuntu.com/job/net-cpp-ci/7/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-amd64-ci/7
    SUCCESS: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-armhf-ci/7
        deb: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-armhf-ci/7/artifact/work/output/*zip*/output.zip
    SUCCESS: http://jenkins.qa.ubuntu.com/job/net-cpp-vivid-i386-ci/7