Media Hub

Merge lp://staging/~thomas-voss/media-hub/switch-to-properties-cpp into lp://staging/media-hub

switch-to-properties-cpp
Merge into trunk

Proposed by Thomas Voß on 2014-02-12

Status:	Merged
Approved by:	Jim Hodapp on 2014-02-14
Approved revision:	33
Merged at revision:	24
Proposed branch:	lp://staging/~thomas-voss/media-hub/switch-to-properties-cpp
Merge into:	lp://staging/media-hub
Diff against target:	3927 lines (+831/-1668) 57 files modified CMakeLists.txt (+4/-2) debian/control (+4/-0) debian/libmusic-hub0.install (+1/-0) debian/rules (+4/-1) include/core/media/connection.h (+0/-71) include/core/media/player.h (+22/-22) include/core/media/property.h (+0/-140) include/core/media/signal.h (+0/-149) include/core/media/track.h (+0/-2) include/core/media/track_list.h (+10/-9) src/core/media/CMakeLists.txt (+4/-1) src/core/media/codec.h (+95/-18) src/core/media/connection.cpp (+0/-71) src/core/media/engine.cpp (+1/-0) src/core/media/engine.h (+6/-5) src/core/media/gstreamer/bus.h (+2/-6) src/core/media/gstreamer/engine.cpp (+19/-19) src/core/media/gstreamer/engine.h (+4/-4) src/core/media/gstreamer/meta_data_extractor.h (+1/-1) src/core/media/gstreamer/playbin.h (+7/-7) src/core/media/mpris/macros.h (+1/-1) src/core/media/mpris/player.h (+9/-8) src/core/media/mpris/track_list.h (+8/-6) src/core/media/player.cpp (+0/-1) src/core/media/player_configuration.h (+2/-2) src/core/media/player_implementation.cpp (+0/-2) src/core/media/player_implementation.h (+1/-1) src/core/media/player_skeleton.cpp (+168/-169) src/core/media/player_skeleton.h (+33/-33) src/core/media/player_stub.cpp (+108/-107) src/core/media/player_stub.h (+23/-23) src/core/media/player_traits.h (+2/-5) src/core/media/property_stub.h (+0/-244) src/core/media/server/server.cpp (+0/-1) src/core/media/service_skeleton.cpp (+7/-6) src/core/media/service_skeleton.h (+2/-2) src/core/media/service_stub.cpp (+2/-2) src/core/media/service_stub.h (+2/-2) src/core/media/service_traits.h (+2/-5) src/core/media/the_session_bus.cpp (+7/-7) src/core/media/the_session_bus.h (+2/-2) src/core/media/track.cpp (+0/-1) src/core/media/track_list_implementation.cpp (+2/-4) src/core/media/track_list_implementation.h (+1/-1) src/core/media/track_list_skeleton.cpp (+56/-59) src/core/media/track_list_skeleton.h (+15/-15) src/core/media/track_list_stub.cpp (+21/-22) src/core/media/track_list_stub.h (+9/-9) src/core/media/track_list_traits.h (+2/-5) tests/CMakeLists.txt (+0/-1) tests/acceptance-tests/CMakeLists.txt (+5/-3) tests/acceptance-tests/service.cpp (+139/-68) tests/cross_process_sync.cpp (+0/-150) tests/cross_process_sync.h (+0/-58) tests/fork_and_run.h (+0/-101) tests/unit-tests/test-gstreamer-engine.cpp (+12/-12) tests/waitable_state_transition.h (+6/-2)
To merge this branch:	bzr merge lp://staging/~thomas-voss/media-hub/switch-to-properties-cpp
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jim Hodapp (community)		2014-02-12	Approve on 2014-02-14
PS Jenkins bot	continuous-integration		Approve on 2014-02-14
Review via email: mp+205993@code.staging.launchpad.net

Commit message

Add build-dependency on libproperties-cpp-dev.
Get rid of local property and signal implementations.

Description of the change

Add build-dependency on libproperties-cpp-dev.
Get rid of local property and signal implementations.

lp://staging/~thomas-voss/media-hub/switch-to-properties-cpp updated on 2014-02-12

26. By Thomas Voß on 2014-02-12: Remove custom Signal::Connection class.

Revision history for this message

Jim Hodapp (jhodapp) wrote on 2014-02-12:

Looks good.

review: Approve

Revision history for this message

Jim Hodapp (jhodapp) wrote on 2014-02-12:

I was a bit hasty approving last time, I discovered a compile issue:

/home/phablet/switch-to-properties-cpp/tests/acceptance-tests/service.cpp:45:39: error: narrowing conversion of ‘((& ms)->std::chrono::duration<_Rep, _Period>::count<long long int, std::ratio<1ll, 1000ll> >() * 1000000ll)’ from ‘std::chrono::duration<long long int, std::ratio<1ll, 1000ll> >::rep {aka long long int}’ to ‘__syscall_slong_t {aka long int}’ inside { } [-Werror=narrowing]
timespec ts{ 0, ms.count() * 1000 * 1000};