Media Hub

Merge lp://staging/~thomas-voss/media-hub/indicator-and-bluez-integration into lp://staging/media-hub

  1. indicator-and-bluez-integration
  2. Merge into trunk
Proposed by Thomas Voß
Status: Needs review
Proposed branch: lp://staging/~thomas-voss/media-hub/indicator-and-bluez-integration
Merge into: lp://staging/media-hub
Diff against target: 4022 lines (+2214/-787)
26 files modified
src/core/media/apparmor.h (+5/-12)
src/core/media/bluez/bluez.h (+350/-0)
src/core/media/gstreamer/engine.cpp (+3/-1)
src/core/media/mpris/media_player2.h (+177/-0)
src/core/media/mpris/mpris.h (+27/-0)
src/core/media/mpris/player.h (+236/-40)
src/core/media/player_implementation.cpp (+268/-118)
src/core/media/player_implementation.h (+32/-4)
src/core/media/player_p.h (+62/-0)
src/core/media/player_skeleton.cpp (+269/-366)
src/core/media/player_skeleton.h (+112/-7)
src/core/media/player_stub.cpp (+108/-97)
src/core/media/player_stub.h (+12/-6)
src/core/media/server/server.cpp (+9/-1)
src/core/media/service_implementation.cpp (+285/-7)
src/core/media/service_implementation.h (+23/-3)
src/core/media/service_skeleton.cpp (+5/-1)
src/core/media/service_stub.cpp (+51/-18)
src/core/media/service_stub.h (+5/-4)
src/core/media/track_list_implementation.cpp (+6/-9)
src/core/media/track_list_implementation.h (+10/-3)
src/core/media/track_list_skeleton.cpp (+17/-19)
src/core/media/track_list_skeleton.h (+11/-3)
src/core/media/track_list_stub.cpp (+32/-55)
src/core/media/track_list_stub.h (+32/-8)
tests/acceptance-tests/service.cpp (+67/-5)
To merge this branch: bzr merge lp://staging/~thomas-voss/media-hub/indicator-and-bluez-integration
Reviewer Review Type Date Requested Status
PS Jenkins bot continuous-integration Needs Fixing
Jim Hodapp Pending
Review via email: mp+225839@code.staging.launchpad.net

Commit message

Wires up the per-player sessions to:

  * MPRIS, by owning an MPRIS-compliant name on the bus
  * Bluez, for enabling remote control of music-playback from bluetooth devices

Description of the change

Wires up the per-player sessions to:

  * MPRIS, by owning an MPRIS-compliant name on the bus
  * Bluez, for enabling remote control of music-playback from bluetooth devices

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:63
http://jenkins.qa.ubuntu.com/job/media-hub-ci/76/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-amd64-ci/18/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-armhf-ci/17/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/media-hub-utopic-i386-ci/16/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/media-hub-ci/76/rebuild

review: Needs Fixing (continuous-integration)
Reply

Unmerged revisions

63. By Thomas Voß

Factor out initialization of player properties.
Wire up property changes.

62. By Thomas Voß

Switch to immediate announcement policy for property updates on the MPRIS player skeleton.

61. By Thomas Voß

Add DesktopEntry property for mpris skeleton.
Make sure that org.mpris.MediaPlayer2 properties are initialized to sensible values.

60. By Thomas Voß

Switch to custom service names to expose mpris instances on the session bus.

59. By Thomas Voß

Restore original interface naming rules.

58. By Thomas Voß

Fix service name generation.

57. By Thomas Voß

Make mpris skeletons reusable.

56. By Thomas Voß

Add some debugging output.

55. By Thomas Voß

Announce track changes to bluez only when track actually changes.

54. By Thomas Voß

Query duration of tracks whenever meta-data changes.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches