Merge lp://staging/~thomas-voss/location-service/refactor-location-position into lp://staging/location-service

Proposed by Thomas Voß
Status: Merged
Approved by: Thomas Voß
Approved revision: 265
Merged at revision: 265
Proposed branch: lp://staging/~thomas-voss/location-service/refactor-location-position
Merge into: lp://staging/location-service
Prerequisite: lp://staging/~thomas-voss/location-service/add-ichnaea-provider-next
Diff against target: 3174 lines (+699/-1100)
56 files modified
include/location/accuracy.h (+0/-72)
include/location/criteria.h (+4/-4)
include/location/heading.h (+0/-29)
include/location/position.h (+104/-26)
include/location/provider.h (+2/-4)
include/location/service.h (+2/-4)
include/location/space_vehicle.h (+6/-6)
include/location/units/units.h (+17/-17)
include/location/velocity.h (+0/-29)
include/location/wgs84/altitude.h (+0/-42)
include/location/wgs84/coordinate.h (+0/-78)
include/location/wgs84/latitude.h (+0/-59)
include/location/wgs84/longitude.h (+0/-59)
src/location/cmds/monitor.cpp (+4/-4)
src/location/cmds/monitor.h (+4/-6)
src/location/dbus/codec.h (+33/-87)
src/location/dbus/skeleton/session.cpp (+4/-4)
src/location/dbus/skeleton/session.h (+2/-4)
src/location/dbus/stub/session.cpp (+2/-2)
src/location/dbus/stub/session.h (+0/-2)
src/location/engine.h (+2/-2)
src/location/position.cpp (+218/-55)
src/location/providers/dummy/provider.cpp (+12/-28)
src/location/providers/dummy/provider.h (+11/-25)
src/location/providers/fusion/newer_or_more_accurate_update_selector.h (+3/-3)
src/location/providers/fusion/provider.cpp (+4/-4)
src/location/providers/fusion/provider.h (+4/-4)
src/location/providers/fusion/update_selector.h (+6/-0)
src/location/providers/gps/android_hardware_abstraction_layer.cpp (+23/-35)
src/location/providers/gps/android_hardware_abstraction_layer.h (+6/-6)
src/location/providers/gps/hardware_abstraction_layer.h (+2/-4)
src/location/providers/gps/provider.cpp (+6/-6)
src/location/providers/gps/provider.h (+4/-4)
src/location/providers/mls/provider.cpp (+6/-9)
src/location/providers/mls/provider.h (+4/-4)
src/location/providers/proxy.cpp (+4/-4)
src/location/providers/proxy.h (+4/-4)
src/location/providers/remote/interface.h (+0/-3)
src/location/providers/remote/provider.cpp (+16/-16)
src/location/providers/remote/provider.h (+12/-12)
src/location/providers/state_tracking_provider.cpp (+2/-2)
src/location/providers/state_tracking_provider.h (+2/-2)
src/location/session_with_provider.cpp (+2/-2)
src/location/time_based_update_policy.cpp (+23/-14)
src/location/time_based_update_policy.h (+5/-5)
src/location/update_policy.h (+2/-4)
tests/CMakeLists.txt (+0/-1)
tests/acceptance_tests.cpp (+4/-10)
tests/mock_event_consumer.h (+2/-2)
tests/mock_provider.h (+6/-6)
tests/position_test.cpp (+16/-22)
tests/reference_position_updated_test.cpp (+4/-15)
tests/remote_provider_test.cpp (+14/-25)
tests/state_tracking_provider_test.cpp (+19/-23)
tests/time_based_update_policy_test.cpp (+67/-72)
tests/wgs84_test.cpp (+0/-129)
To merge this branch: bzr merge lp://staging/~thomas-voss/location-service/refactor-location-position
Reviewer Review Type Date Requested Status
Simon Fels (community) Approve
Thomas Voß Pending
Review via email: mp+303288@code.staging.launchpad.net

Commit message

Refactor location::Position.

 - refactor explicit typing of Latitude/Longitude and instead
   just use units as types.
 - remove explicit types for heading and velocity.

Description of the change

Refactor location::Position.

 - refactor explicit typing of Latitude/Longitude and instead
   just use units as types.
 - remove explicit types for heading and velocity.

To post a comment you must log in.
Revision history for this message
Simon Fels (morphis) wrote :

LGTM

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: