Merge lp://staging/~thomas-voss/location-service/add-ubx-provider into lp://staging/location-service
Proposed by
Thomas Voß
| Status: | Merged |
|---|---|
| Approved by: | Thomas Voß |
| Approved revision: | 278 |
| Merged at revision: | 275 |
| Proposed branch: | lp://staging/~thomas-voss/location-service/add-ubx-provider |
| Merge into: | lp://staging/location-service |
| Diff against target: |
2864 lines (+2611/-12) 39 files modified
CMakeLists.txt (+0/-5) snapcraft.yaml (+12/-7) src/location/providers/CMakeLists.txt (+1/-0) src/location/providers/config.cpp (+7/-0) src/location/providers/ubx/CMakeLists.txt (+18/-0) src/location/providers/ubx/_8/marshaller.h (+42/-0) src/location/providers/ubx/_8/message.h (+56/-0) src/location/providers/ubx/_8/nmea/cardinal_direction.h (+43/-0) src/location/providers/ubx/_8/nmea/date.h (+43/-0) src/location/providers/ubx/_8/nmea/fusion_adapt.h (+134/-0) src/location/providers/ubx/_8/nmea/generator.h (+254/-0) src/location/providers/ubx/_8/nmea/gga.h (+69/-0) src/location/providers/ubx/_8/nmea/gll.h (+56/-0) src/location/providers/ubx/_8/nmea/gps/fix_mode.h (+50/-0) src/location/providers/ubx/_8/nmea/grammar.h (+251/-0) src/location/providers/ubx/_8/nmea/gsa.h (+84/-0) src/location/providers/ubx/_8/nmea/gsv.h (+66/-0) src/location/providers/ubx/_8/nmea/latitude.h (+42/-0) src/location/providers/ubx/_8/nmea/longitude.h (+42/-0) src/location/providers/ubx/_8/nmea/mode.h (+44/-0) src/location/providers/ubx/_8/nmea/rmc.h (+68/-0) src/location/providers/ubx/_8/nmea/scanner.cpp (+65/-0) src/location/providers/ubx/_8/nmea/scanner.h (+67/-0) src/location/providers/ubx/_8/nmea/sentence.cpp (+81/-0) src/location/providers/ubx/_8/nmea/sentence.h (+56/-0) src/location/providers/ubx/_8/nmea/status.h (+40/-0) src/location/providers/ubx/_8/nmea/talker.h (+41/-0) src/location/providers/ubx/_8/nmea/txt.h (+55/-0) src/location/providers/ubx/_8/nmea/utc.h (+43/-0) src/location/providers/ubx/_8/nmea/vtg.h (+53/-0) src/location/providers/ubx/_8/receiver.cpp (+23/-0) src/location/providers/ubx/_8/receiver.h (+81/-0) src/location/providers/ubx/_8/replaying_receiver.cpp (+32/-0) src/location/providers/ubx/_8/scanner.h (+146/-0) src/location/providers/ubx/_8/serial_port_receiver.cpp (+44/-0) src/location/providers/ubx/_8/serial_port_receiver.h (+72/-0) src/location/providers/ubx/dop.h (+60/-0) src/location/providers/ubx/provider.cpp (+160/-0) src/location/providers/ubx/provider.h (+110/-0) |
| To merge this branch: | bzr merge lp://staging/~thomas-voss/location-service/add-ubx-provider |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomas Voß | Approve | ||
| Scott Sweeny (community) | code | Needs Information | |
|
Review via email:
|
|||
Commit message
Add ubx provider implementation.
Description of the change
Add ubx provider implementation.
To post a comment you must log in.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Overall the code LGTM.
Could you clarify why you removed the LGPL test and explain a bit about the new commands?
Thanks.