dbus-cpp

Merge lp://staging/~thomas-voss/dbus-cpp/fix-destruction-of-bus-instances into lp://staging/dbus-cpp

  1. fix-destruction-of-bus-instances
  2. Merge into trunk
Proposed by Thomas Voß
Status: Needs review
Proposed branch: lp://staging/~thomas-voss/dbus-cpp/fix-destruction-of-bus-instances
Merge into: lp://staging/dbus-cpp
Diff against target: 293 lines (+135/-84)
2 files modified
src/core/dbus/bus.cpp (+129/-74)
tests/executor_test.cpp (+6/-10)
To merge this branch: bzr merge lp://staging/~thomas-voss/dbus-cpp/fix-destruction-of-bus-instances
Reviewer Review Type Date Requested Status
Manuel de la Peña (community) Approve
PS Jenkins bot continuous-integration Needs Fixing
Ricardo Mendoza Pending
Review via email: mp+224921@code.staging.launchpad.net

Commit message

Fix core::dbus::Bus desctruction and do not call dbus_shutdown unless explicitly requested by setting the env var DBUS_CPP_ENABLE_SHUTDOWN to 1

Description of the change

Fix destruction of core::dbus::Bus instances and do not call dbus_shutdown unless explicitly requested by setting DBUS_CPP_ENABLE_SHUTDOWN to 1 in the env of the process.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:61
http://jenkins.qa.ubuntu.com/job/dbus-cpp-ci/182/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/dbus-cpp-utopic-amd64-ci/22/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/dbus-cpp-utopic-armhf-ci/22/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/dbus-cpp-utopic-i386-ci/22/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/dbus-cpp-ci/182/rebuild

review: Needs Fixing (continuous-integration)
Reply
Revision history for this message
Manuel de la Peña (mandel) :
review: Approve
Reply
Revision history for this message
Dimitri John Ledkov (xnox) wrote :

is this going to land?

Reply

Unmerged revisions

61. By Thomas Voß

Adjust name of env variable to DBUS_CPP_ENABLE_SHUTDOWN.

60. By Thomas Voß

Fix destruction of core::dbus::Bus instances.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches