biometryd

Merge lp://staging/~thomas-voss/biometryd/initial-landing into lp://staging/biometryd

Proposed by Thomas Voß on 2016-05-02

Status:	Merged
Approved by:	Ken VanDine on 2016-06-17
Approved revision:	17
Merged at revision:	30
Proposed branch:	lp://staging/~thomas-voss/biometryd/initial-landing
Merge into:	lp://staging/biometryd
Diff against target:	1479 lines (+1027/-75) 16 files modified doc/manual_test_plan.md (+43/-0) include/biometry/devices/fingerprint_reader.h (+29/-1) src/biometry/devices/fingerprint_reader.cpp (+17/-9) src/biometry/qml/Biometryd/CMakeLists.txt (+4/-1) src/biometry/qml/Biometryd/converter.cpp (+50/-0) src/biometry/qml/Biometryd/converter.h (+49/-0) src/biometry/qml/Biometryd/fingerprint_reader.cpp (+70/-0) src/biometry/qml/Biometryd/fingerprint_reader.h (+77/-0) src/biometry/qml/Biometryd/operation.cpp (+7/-0) src/biometry/qml/Biometryd/operation.h (+231/-36) src/biometry/qml/Biometryd/plugin.cpp (+317/-21) src/biometry/qml/Biometryd/service.cpp (+15/-1) src/biometry/qml/Biometryd/service.h (+13/-2) src/biometry/qml/Biometryd/template_store.cpp (+10/-0) src/biometry/qml/Biometryd/template_store.h (+24/-0) tests/tst_qml_plugin.qml (+71/-4)
To merge this branch:	bzr merge lp://staging/~thomas-voss/biometryd/initial-landing
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Jonas G. Drange (community)		2016-05-02	Approve on 2016-06-17
Review via email: mp+293499@code.staging.launchpad.net

Only for landing purposes.

Only for landing purposes.

2. By Thomas Voß on 2016-05-02: Fix up pkgconfig file.
3. By Thomas Voß on 2016-05-02: Add a qml::for_testing::* stack that enables users of the QML bindings to test async behavior.
Factor out conversion from biometry::* to biometry::qml::* types.
4. By Thomas Voß on 2016-05-02: Factor FingerprintReaderHints .
5. By Thomas Voß on 2016-05-03: Expose additional hints for fingerprint readers.
Add documentation to qml test case.
6. By Thomas Voß on 2016-05-04: Correctly propagate result of operations to qml::Biometryd::Observer.
Correctly propagete FingerprintReader::is_finger_present hint to qml::Biometryd::Observer.
7. By Thomas Voß on 2016-05-05: Make the testing backend stateful and keep track of number of enrolled templates.
8. By Thomas Voß on 2016-05-24: QRect assumes (x,y) and (w,h) on construction.
9. By Thomas Voß on 2016-05-24: Fix typo.
10. By Thomas Voß on 2016-05-25: Merge trunk.
11. By Thomas Voß on 2016-05-25: Switch to QRectF.
12. By Thomas Voß on 2016-05-31: Gracefully handle the service not being present in QML bindings.

Revision history for this message

Jonas G. Drange (jonas-drange) wrote on 2016-06-02:

Small comment on the ambiguity of the API for available and defaultDevice.

review: Needs Information

13. By Thomas Voß on 2016-06-13: Dummy enrollment/identification operations now take 5 seconds in total.
14. By Thomas Voß on 2016-06-15: Merge trunk.
15. By Thomas Voß on 2016-06-15: Support List/Removal operations in qml bindings.
16. By Thomas Voß on 2016-06-15: Fix a race on cancellation/destruction with the Observer::on_cancelled implementation accessing a dangling QObject pointer.