Merge lp://staging/~thomas-noel/fast-user-switch-applet/never-even-max-users into lp://staging/~ted/fast-user-switch-applet/max-users

Proposed by Thomas NOEL
Status: Needs review
Proposed branch: lp://staging/~thomas-noel/fast-user-switch-applet/never-even-max-users
Merge into: lp://staging/~ted/fast-user-switch-applet/max-users
Diff against target: None lines
To merge this branch: bzr merge lp://staging/~thomas-noel/fast-user-switch-applet/never-even-max-users
To post a comment you must log in.
Revision history for this message
Thomas NOEL (thomas-noel) wrote :

When a system is network managed with libnss-mysql or ldap, it is common to
have 200 users or more...

But for such a system, if I want to set "/apps/fusa/show_screen_item" to
"never" (do not show "Switch User"), it doesn't work because we are in a
"password_overload" case.

So my proposition is to modify the function reset_login_screen_item() in
src/applet.c : it checks if "show_screen_item=never" first.

Revision history for this message
Jean Christophe André (progfou) wrote :

I second this... It's important to be able to switch this functionnality off when required!

Unmerged revisions

473. By Thomas NOEL <thomas@thomas-pc>

show_screen_item : "never" should precede "always"

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'src/applet.c'
2--- src/applet.c 2008-10-31 19:55:16 +0000
3+++ src/applet.c 2009-05-05 18:09:00 +0000
4@@ -1946,11 +1946,12 @@
5 const gchar *pref_value,
6 FusaManager * manager)
7 {
8- if (!pref_value || strcmp (pref_value, "always") == 0 || fusa_manager_get_passwd_overload(manager))
9+ if (pref_value && strcmp (pref_value, "never") == 0)
10+ gtk_widget_hide (widget);
11+ else if (!pref_value || strcmp (pref_value, "always") == 0 ||
12+ fusa_manager_get_passwd_overload(manager))
13 gtk_widget_show (widget);
14- else if (pref_value && strcmp (pref_value, "never") == 0)
15- gtk_widget_hide (widget);
16- else if (use_xnest_value)
17+ else if (use_xnest_value) /* "auto" */
18 gtk_widget_hide (widget);
19 else
20 gtk_widget_show (widget);

Subscribers

People subscribed via source and target branches