Merge lp://staging/~thisfred/ubuntuone-client/lp-702055 into lp://staging/ubuntuone-client
Proposed by
Eric Casteleijn
Status: | Merged |
---|---|
Approved by: | dobey |
Approved revision: | 851 |
Merged at revision: | 854 |
Proposed branch: | lp://staging/~thisfred/ubuntuone-client/lp-702055 |
Merge into: | lp://staging/ubuntuone-client |
Diff against target: |
501 lines (+173/-63) 6 files modified
tests/platform/linux/test_messaging.py (+8/-3) tests/status/test_aggregator.py (+90/-27) ubuntuone/platform/linux/messaging.py (+28/-11) ubuntuone/platform/windows/messaging.py (+15/-8) ubuntuone/status/aggregator.py (+28/-12) ubuntuone/status/messaging.py (+4/-2) |
To merge this branch: | bzr merge lp://staging/~thisfred/ubuntuone-client/lp-702055 |
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Natalia Bidart (community) | Approve | ||
Alejandro J. Cura (community) | Approve | ||
Review via email: mp+48987@code.staging.launchpad.net |
Commit message
This adds notifications and messaging on new incoming shares and UDFs.
Description of the change
This adds notifications and messaging on new incoming shares and UDFs.
To post a comment you must log in.
Great branch!
Two small issues: show_message, just like new_udf_available _callback should be named more descriptively.
* I think that new_share_available in StatusFrontend should also pass _callback to messaging.
* I think that StatusFrontend.
Otherwise great work :-)