Merge lp://staging/~thisfred/u1db/basic-auth2 into lp://staging/u1db

Proposed by Eric Casteleijn
Status: Merged
Approved by: Eric Casteleijn
Approved revision: 400
Merged at revision: 399
Proposed branch: lp://staging/~thisfred/u1db/basic-auth2
Merge into: lp://staging/u1db
Diff against target: 72 lines (+16/-10)
2 files modified
u1db/remote/basic_auth_middleware.py (+8/-3)
u1db/tests/test_auth_middleware.py (+8/-7)
To merge this branch: bzr merge lp://staging/~thisfred/u1db/basic-auth2
Reviewer Review Type Date Requested Status
John O'Brien (community) Approve
Review via email: mp+124042@code.staging.launchpad.net

Commit message

- simplified basic auth middleware and changed the verify_user signature based on server side needs.

Description of the change

- simplified basic auth middleware and changed the verify_user signature based on server side needs.

To post a comment you must log in.
Revision history for this message
John O'Brien (jdobrien) wrote :

Looks good.

review: Approve
Revision history for this message
Ubuntu One Auto Pilot (otto-pilot) wrote :

The attempt to merge lp:~thisfred/u1db/basic-auth2 into lp:u1db failed. Below is the output from the failed tests.

/bin/sh: 1: cmake: not found

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches