desktopcouch

Merge lp://staging/~thisfred/desktopcouch/a-b-c-1-2-3 into lp://staging/desktopcouch

  1. a-b-c-1-2-3
  2. Merge into trunk
Proposed by Eric Casteleijn
Status: Merged
Approved by: Vincenzo Di Somma
Approved revision: 215
Merged at revision: 215
Proposed branch: lp://staging/~thisfred/desktopcouch/a-b-c-1-2-3
Merge into: lp://staging/desktopcouch
Diff against target: 874 lines (+272/-298)
6 files modified
desktopcouch/records/doc/field_registry.txt (+2/-2)
desktopcouch/records/field_registry.py (+61/-18)
desktopcouch/records/record.py (+66/-142)
desktopcouch/records/server_base.py (+3/-2)
desktopcouch/records/tests/test_field_registry.py (+16/-13)
desktopcouch/records/tests/test_record.py (+124/-121)
To merge this branch: bzr merge lp://staging/~thisfred/desktopcouch/a-b-c-1-2-3
Reviewer Review Type Date Requested Status
Vincenzo Di Somma (community) Approve
Manuel de la Peña (community) Approve
Review via email: mp+41421@code.staging.launchpad.net

Commit message

Makes RecordDict and MergeableList use Abstract Base Classes, so the code is smaller, and the interfaces are more guaranteed.

Description of the change

Makes RecordDict and MergeableList use Abstract Base Classes, so the code is smaller, and the interfaces are more guaranteed.

Note this has some small and rather trivial lint issues, which I have already fixed on other branches, and I don't want to generate more conflicts than I have to.

To post a comment you must log in.
Revision history for this message
Manuel de la Peña (mandel) wrote :

+1, good job you workaholic!

review: Approve
Revision history for this message
Nicola Larosa (teknico) wrote :

You might want to add a comment to record.py, right before importing MutableSequence and MutableMapping, to the effect that it requires at least Python 2.6 .

This will make this and subsequent versions of desktopcouch not usable by ubuntuone-servers, until all server machines are upgraded to Lucid (10.04).

Revision history for this message
Vincenzo Di Somma (vds) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches