Merge lp://staging/~therve/txamqp/fix-rabbit-failures into lp://staging/txamqp

Proposed by Thomas Herve
Status: Merged
Approved by: Esteve Fernandez
Approved revision: 56
Merged at revision: 55
Proposed branch: lp://staging/~therve/txamqp/fix-rabbit-failures
Merge into: lp://staging/txamqp
Diff against target: 353 lines (+45/-39)
4 files modified
src/txamqp/test/test_basic.py (+29/-22)
src/txamqp/test/test_exchange.py (+2/-4)
src/txamqp/test/test_queue.py (+13/-12)
src/txamqp/testlib.py (+1/-1)
To merge this branch: bzr merge lp://staging/~therve/txamqp/fix-rabbit-failures
Reviewer Review Type Date Requested Status
Esteve Fernandez Approve
Review via email: mp+38651@code.staging.launchpad.net

Description of the change

So the branch mainly fixes the path to the spec file, but also skip a bunch of tests.

With those changes it's now green for me with the 2.1 release.

To post a comment you must log in.
Revision history for this message
Thomas Herve (therve) wrote :

I updated to make it work with 2.2.

56. By Thomas Herve

Skip some more tests

Revision history for this message
Esteve Fernandez (esteve) wrote :

Sorry for the slow review. +1 It looks great! I think we should drop support for OpenAMQ, it's no longer maintained, but we can remove it in a later branch/ticket.

Thanks!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to status/vote changes: