Merge lp://staging/~therve/storm/flush-order-673666 into lp://staging/storm
Proposed by
Thomas Herve
Status: | Needs review | ||||
---|---|---|---|---|---|
Proposed branch: | lp://staging/~therve/storm/flush-order-673666 | ||||
Merge into: | lp://staging/storm | ||||
Diff against target: | 48 lines (+27/-0) | ||||
To merge this branch: | bzr merge lp://staging/~therve/storm/flush-order-673666 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Gustavo Niemeyer | Needs Information | ||
Storm Developers | Pending | ||
Review via email: mp+40783@code.staging.launchpad.net |
Description of the change
The test case was fairly easy to create, and the fix as well. I'm not convinced this is the best fix, but it seems to be reasonable enough.
To post a comment you must log in.
Unmerged revisions
- 385. By Thomas Herve
-
Try another approach
- 384. By Thomas Herve
-
Add a test, and one possible fix.
[1]
Yeah, this looks quite simple, but it seems to be hiding a bug somewhere else.
The obvious question is why did the pair survive for that long elsewhere, rather than
getting cleaned up when the transaction was flushed?