Merge lp://staging/~therve/landscape-client/remove-mount-activity into lp://staging/~landscape/landscape-client/trunk
Proposed by
Thomas Herve
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Björn Tillenius | ||||
| Approved revision: | 301 | ||||
| Merged at revision: | 301 | ||||
| Proposed branch: | lp://staging/~therve/landscape-client/remove-mount-activity | ||||
| Merge into: | lp://staging/~landscape/landscape-client/trunk | ||||
| Diff against target: |
338 lines (+38/-131) 2 files modified
landscape/monitor/mountinfo.py (+4/-24) landscape/monitor/tests/test_mountinfo.py (+34/-107) |
||||
| To merge this branch: | bzr merge lp://staging/~therve/landscape-client/remove-mount-activity | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Björn Tillenius (community) | Approve | ||
| Kevin McDermott (community) | Approve | ||
|
Review via email:
|
|||
Description of the change
The branch removes the generation of the message, but not the message schema itself: we need it in the server for backward compatibility.
To post a comment you must log in.
Revision history for this message
| Kevin McDermott (bigkevmcd) wrote | # |
Revision history for this message
| Kevin McDermott (bigkevmcd) | # |
review:
Approve
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Looks good to me, shame we can't remove the schema entry...
Is it worth while doing work to have DEPRECATED_SCHEMAs or something, which can be dropped when they're sent to the server?