Landscape Client

Merge lp://staging/~therve/landscape-client/package-reporter-errors into lp://staging/~landscape/landscape-client/trunk

  1. package-reporter-errors
  2. Merge into trunk
Proposed by Thomas Herve
Status: Merged
Approved by: Björn Tillenius
Approved revision: 327
Merged at revision: 328
Proposed branch: lp://staging/~therve/landscape-client/package-reporter-errors
Merge into: lp://staging/~landscape/landscape-client/trunk
Diff against target: 128 lines (+55/-9)
3 files modified
landscape/message_schemas.py (+11/-7)
landscape/package/reporter.py (+18/-1)
landscape/package/tests/test_reporter.py (+26/-1)
To merge this branch: bzr merge lp://staging/~therve/landscape-client/package-reporter-errors
Reviewer Review Type Date Requested Status
Björn Tillenius (community) Approve
Free Ekanayaka (community) Approve
Review via email: mp+59529@code.staging.launchpad.net

Description of the change

That part is of course too easy. The reporter just sends a new message when a smart update fails. We need to do something on the server side to handle it. I was thinking about adding an alert?

To post a comment you must log in.
Revision history for this message
Free Ekanayaka (free.ekanayaka) wrote :

Looks good, +1.

An alert sounds fine, though sometimes the errors might be transient, like an HTTP timeout.

review: Approve
Revision history for this message
Björn Tillenius (bjornt) wrote :

Looks good to me, +1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: