Web addons for OpenERP

Merge lp://staging/~therp-nl/web-addons/7.0-web_relativedelta into lp://staging/~webaddons-core-editors/web-addons/7.0

7.0-web_relativedelta
Merge into 7.0

Proposed by Holger Brunn (Therp) on 2014-04-29

Status:	Rejected
Rejected by:	Holger Brunn (Therp) on 2014-07-07
Proposed branch:	lp://staging/~therp-nl/web-addons/7.0-web_relativedelta
Merge into:	lp://staging/~webaddons-core-editors/web-addons/7.0
Prerequisite:	lp://staging/~therp-nl/web-addons/7.0-web_relativedelta_momentjs
Diff against target:	377 lines (+352/-0) 4 files modified web_relativedelta/__init__.py (+20/-0) web_relativedelta/__openerp__.py (+77/-0) web_relativedelta/static/src/js/web_relativedelta.js (+179/-0) web_relativedelta/static/test/web_relativedelta.js (+76/-0)
To merge this branch:	bzr merge lp://staging/~therp-nl/web-addons/7.0-web_relativedelta
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Holger Brunn (Therp)		Needs Resubmitting on 2014-07-07
Stefan Rijnhart (Opener)	2014-04-29	Needs Information on 2014-04-29
Review via email: mp+217653@code.staging.launchpad.net

Description of the change

Reimplementation of relativedelta for use in client side domains in the hope that it sucks less than the one provided in upstream.

This uses http://momentjs.com which was committed separately to simplify the review.

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2014-04-29:

Thanks! Code looks clean enough. But I was wondering about the rationale. Can you give an example how to use this in a custom module (I assume)? Why do you 'hope' it sucks less, I mean, what is bad about the standard implementation in the OpenERP web client? Why not propose this into upstream OpenERP web client trunk then?

review: Needs Information

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-04-29:

The hope part is modesty and the fact that I'm not sure that the day= parameter is handled correctly.

What is bad about the standard implementation:
- no weekday, so there's no chance to have filters for the current (calendar) week, next week, etc
- no datetimes, only date
- no hours, minute, second
- negative days are not properly implemented

For an example:
Just use relativedelta as usual, but without the drawbacks as described above

lp://staging/~therp-nl/web-addons/7.0-web_relativedelta updated on 2014-04-30

36. By Holger Brunn (Therp) on 2014-04-30: [IMP] sanitize input for absolute values
[IMP] handle day parameter correctly (don't cross month boundaries)

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-04-30:

The MP for trunk can be found here: https://code.launchpad.net/~therp-nl/openerp-web/trunk-relativedelta-momentjs/+merge/217734

lp://staging/~therp-nl/web-addons/7.0-web_relativedelta updated on 2014-07-01

37. By Holger Brunn (Therp) on 2014-06-30: [FIX] actually use relativedelta's semantics for weekdays
38. By Holger Brunn (Therp) on 2014-06-30: [ADD] tests
[ADD] more detail in manifest
39. By Holger Brunn (Therp) on 2014-07-01: [ADD] actually add tests

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-07-07:

This project is now hosted on https://github.com/OCA/web. Please move your proposal there. This guide may help you https://github.com/OCA/maintainers-tools/wiki/How-to-move-a-Merge-Proposal-to-GitHub

review: Needs Resubmitting

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2014-07-07:

https://github.com/OCA/web/pull/9

Unmerged revisions

39. By Holger Brunn (Therp) on 2014-07-01: [ADD] actually add tests
38. By Holger Brunn (Therp) on 2014-06-30: [ADD] tests
[ADD] more detail in manifest
37. By Holger Brunn (Therp) on 2014-06-30: [FIX] actually use relativedelta's semantics for weekdays
36. By Holger Brunn (Therp) on 2014-04-30: [IMP] sanitize input for absolute values
[IMP] handle day parameter correctly (don't cross month boundaries)
35. By Holger Brunn (Therp) on 2014-04-29: [ADD] web_relativedelta
34. By Holger Brunn (Therp) on 2014-04-29: [ADD] moment.js