Merge lp://staging/~therp-nl/web-addons/7.0-add_percentage_widget into lp://staging/~webaddons-core-editors/web-addons/7.0
Proposed by
Stefan Rijnhart (Opener)
| Status: | Rejected |
|---|---|
| Rejected by: | Stefan Rijnhart (Opener) |
| Proposed branch: | lp://staging/~therp-nl/web-addons/7.0-add_percentage_widget |
| Merge into: | lp://staging/~webaddons-core-editors/web-addons/7.0 |
| Diff against target: |
149 lines (+124/-0) 4 files modified
web_percent/__init__.py (+20/-0) web_percent/__openerp__.py (+50/-0) web_percent/static/src/js/resource.js (+45/-0) web_percent/static/src/xml/percent.xml (+9/-0) |
| To merge this branch: | bzr merge lp://staging/~therp-nl/web-addons/7.0-add_percentage_widget |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Holger Brunn (Therp) | Needs Resubmitting | ||
| Pedro Manuel Baeza | Needs Information | ||
|
Review via email:
|
|||
Description of the change
Add a simple widget to display floats with a % suffix. Extending a dangling branch from Quentin Theuret (TeMPO).
To post a comment you must log in.
Revision history for this message
| Holger Brunn (Therp) (hbrunn) | # |
review:
Approve
(code review)
Revision history for this message
| Pedro Manuel Baeza (pedro.baeza) wrote | # |
review:
Needs Information
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | # |
Unmerged revisions
- 38. By Stefan Rijnhart (Opener)
-
[ADD] Disclaimer
- 37. By Stefan Rijnhart (Opener)
-
[FIX] Preserve original formatting in tree view
[ADD] Credits - 36. By Stefan Rijnhart (Opener)
-
[ADD] Tree view widget
- 35. By Stefan Rijnhart (Opener)
-
[RFR] Use instance convention
- 34. By Quentin THEURET @Amaris
-
[ADD] Add a new web module that add a new percentage widget that add a percentage symbol after the field value
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Hi, Stefan, thanks for continuing Quentin's work. Minimum requirements that I would expect for a percentage widget would be:
- Automatic conversion from float 0.0-1.0 to screen 0.0-100.0 on data read.
- Inverse conversion on data write.
- Validation of the data domain in 0-100 (optionally through an XML parameter).
Don't you think it's worth to include these features from first version?
Regards.