Therp Addons

Merge lp://staging/~therp-nl/therp-addons/trp_use_case_project into lp://staging/~therp-nl/therp-addons/6.1

trp_use_case_project
Merge into 6.1

Proposed by Holger Brunn (Therp) on 2013-03-05

Status:	Rejected
Rejected by:	Stefan Rijnhart (Opener) on 2013-03-21
Proposed branch:	lp://staging/~therp-nl/therp-addons/trp_use_case_project
Merge into:	lp://staging/~therp-nl/therp-addons/6.1
Prerequisite:	lp://staging/~therp-nl/therp-addons/fetchmail_attach_from_folder
Diff against target:	176 lines (+88/-3) 7 files modified trp_use_case/__openerp__.py (+1/-1) trp_use_case/model/__init__.py (+1/-0) trp_use_case/model/project_task.py (+32/-0) trp_use_case/model/use_case.py (+43/-0) trp_use_case/view/use_case.xml (+2/-1) trp_use_case/view/use_case_collection.xml (+7/-0) trp_use_case/view/use_case_inline.xml (+2/-1)
To merge this branch:	bzr merge lp://staging/~therp-nl/therp-addons/trp_use_case_project
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Holger Brunn (Therp)		Disapprove on 2013-03-21
Stefan Rijnhart (Opener) (community)	2013-03-05	Needs Fixing on 2013-03-21
Review via email: mp+151728@code.staging.launchpad.net

This proposal supersedes a proposal from 2013-03-05.

Description of the change

This patch adds the possibility to create project tasks from a use case collection. That's a very convenient to keep track of what still has to be done during the implementation phase

lp://staging/~therp-nl/therp-addons/trp_use_case_project updated on 2013-03-15

86. By Holger Brunn (Therp) on 2013-03-05: [FIX] pass id instead of browse record
87. By Holger Brunn (Therp) on 2013-03-15: [FIX] write remaining_hours to task being created

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2013-03-20:

Nice and clean, thanks! Here come the nits:

l.78,79 and 90,91: "Arguments on first line forbidden when not using vertical alignment" (PEP8)

l.144: try to prevent very long lines in XML as well. Please rearrange the attributes over various lines (even though the help attribute will still cause a relatively long line by itself).

l.124 and 157: can you pick a separate color for each of the two conditions?

review: Needs Fixing

lp://staging/~therp-nl/therp-addons/trp_use_case_project updated on 2013-03-21

88. By Holger Brunn (Therp) on 2013-03-21: [FIX] pep8
[IMP] different colors for different states

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2013-03-21:

thanks, the changes are commited

Revision history for this message

Stefan Rijnhart (Opener) (stefan-opener) wrote on 2013-03-21:

Thanks. I approve the code in this MP but I cannot merge at this moment due to the dependency on the other MP regarding fetchmail on folders. You could consider rebasing the changes in this MP.

review: Needs Fixing

Revision history for this message

Holger Brunn (Therp) (hbrunn) wrote on 2013-03-21:

denied because of unrelated prerequisite, new branch lp:~therp-nl/therp-addons/trp_use_case_project2 proposed

review: Disapprove

Unmerged revisions

88. By Holger Brunn (Therp) on 2013-03-21: [FIX] pep8
[IMP] different colors for different states
87. By Holger Brunn (Therp) on 2013-03-15: [FIX] write remaining_hours to task being created
86. By Holger Brunn (Therp) on 2013-03-05: [FIX] pass id instead of browse record
85. By Holger Brunn (Therp) on 2013-03-05: [IMP] also gray out done use cases on inline tree
84. By Holger Brunn (Therp) on 2013-03-05: [ADD] allow creating projects/tasks from use cases
83. By Holger Brunn (Therp) on 2013-03-04: [IMP] never attach mails with the same message id twice
82. By Holger Brunn (Therp) on 2013-02-26: [FIX] close connection
81. By Holger Brunn (Therp) on 2013-02-26: [ADD] manual matching for mails
80. By Holger Brunn (Therp) on 2013-02-25: [ADD] module to read an IMAP folder and attach mails to existing objects