Merge lp://staging/~therp-nl/therp-addons/therp-addons_backups into lp://staging/~therp-nl/therp-addons/6.1

Proposed by Holger Brunn (Therp)
Status: Superseded
Proposed branch: lp://staging/~therp-nl/therp-addons/therp-addons_backups
Merge into: lp://staging/~therp-nl/therp-addons/6.1
Diff against target: 430 lines (+377/-0)
10 files modified
trp_encrypted_backup/__init__.py (+22/-0)
trp_encrypted_backup/__openerp__.py (+49/-0)
trp_encrypted_backup/data/ir_config_parameter.xml (+19/-0)
trp_encrypted_backup/data/ir_cron.xml (+17/-0)
trp_encrypted_backup/trp_encrypted_backup.py (+93/-0)
trp_encrypted_backup/trp_encrypted_backup.xml (+33/-0)
trp_encrypted_backup_rsync/__init__.py (+22/-0)
trp_encrypted_backup_rsync/__openerp__.py (+43/-0)
trp_encrypted_backup_rsync/data/ir_config_parameter.xml (+11/-0)
trp_encrypted_backup_rsync/trp_encrypted_backup_rsync.py (+68/-0)
To merge this branch: bzr merge lp://staging/~therp-nl/therp-addons/therp-addons_backups
Reviewer Review Type Date Requested Status
Stefan Rijnhart (Opener) (community) Needs Fixing
Review via email: mp+129266@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2012-10-12.

To post a comment you must log in.
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Holger,

thanks a dozen!

Couple of details:

Could you rename trp_backup to trp_crypt_backup in order to distinguish from other backup modules for OpenERP?
Any reason for the joint copyright with Tiny SPRL?
Please check explicitely for partial transfer exit codes (see http://wpkg.org/Rsync_exit_codes) in that scary indefinite loop.

Cheers,
Stefan.

review: Needs Fixing
55. By Holger Brunn (Therp)

[IMP] renamed modules to better reflect their purpose
[IMP] only restart rsync transfer if the error code indicates a connection
issue
[FIX] fixed copyright notices

Unmerged revisions

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches