Merge lp://staging/~therp-nl/therp-addons/7.0-fetchmail-invoice_fix_journal_selection into lp://staging/~therp-nl/therp-addons/7.0
Proposed by
Stefan Rijnhart (Opener)
| Status: | Merged |
|---|---|
| Merged at revision: | 90 |
| Proposed branch: | lp://staging/~therp-nl/therp-addons/7.0-fetchmail-invoice_fix_journal_selection |
| Merge into: | lp://staging/~therp-nl/therp-addons/7.0 |
| Diff against target: |
21 lines (+3/-2) 1 file modified
fetchmail_invoice/model/fetchmail_invoice.py (+3/-2) |
| To merge this branch: | bzr merge lp://staging/~therp-nl/therp-addons/7.0-fetchmail-invoice_fix_journal_selection |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Holger Brunn (Therp) | code review | Approve | |
| Ronald Portier (Therp) | Approve | ||
|
Review via email:
|
|||
Description of the change
To clarify the possibly suspicious looking diff: the default function for account.invoice's type field looks to the context so I don't need it in the custom_value anymore once it's in the context. And I need it in the context because that's where the default function for journal_id looks to determine the journal type.
To post a comment you must log in.
Revision history for this message
| Holger Brunn (Therp) (hbrunn) | # |
review:
Approve
(code review)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Approve. Code review and test.
Actually integrated the fix in my branch (Work in Progress) to enable fetchmail_invoice for multi-company.