Therp Addons

Merge lp://staging/~therp-nl/therp-addons/7.0-del_trp_report_address_icon into lp://staging/~therp-nl/therp-addons/7.0

  1. 7.0-del_trp_report_address_icon
  2. Merge into 7.0
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 94
Proposed branch: lp://staging/~therp-nl/therp-addons/7.0-del_trp_report_address_icon
Merge into: lp://staging/~therp-nl/therp-addons/7.0
Diff against target: 70 lines (+0/-0)
0 files modified
To merge this branch: bzr merge lp://staging/~therp-nl/therp-addons/7.0-del_trp_report_address_icon
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) Approve
Review via email: mp+193257@code.staging.launchpad.net
To post a comment you must log in.
lp://staging/~therp-nl/therp-addons/7.0-del_trp_report_address_icon updated
95. By Stefan Rijnhart (Opener)

[DEL] On second thought, remove icon from every uninstallable module

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Then again, maybe we should fix this issue of preloading in the server.

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

The culprit is in openerp-web/addons/web/http.py:575, where all modules containing the static directory is loaded. If I simplistically only load modules at this point that have a 'controllers' subdirectory, the web client does not run properly. This is not going to be easy.

Revision history for this message
Ronald Portier (Therp) (rportier1962) wrote :

I do not see a link to a bug on the branch. What is the problem that this should solve?

Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Similar problem to the one already discovered during the proposal to merge these icons here: https://code.launchpad.net/~therp-nl/therp-addons/7.0_icons/+merge/191595. The existence of a 'static' subdirectory triggers the import of the python modules. Regular model definitions and xml data are not loaded, but monkey patches are (that is the problem here), and invalid imports in the modules break the server (problem detected in original proposal).

Revision history for this message
Holger Brunn (Therp) (hbrunn) wrote :

Makes sense for now

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: