Merge lp://staging/~therp-nl/therp-addons/6.1-trp_external_user_analytic_lines into lp://staging/~therp-nl/therp-addons/6.1
Proposed by
Holger Brunn (Therp)
| Status: | Rejected |
|---|---|
| Rejected by: | Holger Brunn (Therp) |
| Proposed branch: | lp://staging/~therp-nl/therp-addons/6.1-trp_external_user_analytic_lines |
| Merge into: | lp://staging/~therp-nl/therp-addons/6.1 |
| Diff against target: |
325 lines (+270/-0) 9 files modified
trp_external_user_analytic_lines/__init__.py (+21/-0) trp_external_user_analytic_lines/__openerp__.py (+63/-0) trp_external_user_analytic_lines/model/__init__.py (+21/-0) trp_external_user_analytic_lines/model/account_analytic_line.py (+79/-0) trp_external_user_analytic_lines/security/ir.model.access.csv (+3/-0) trp_external_user_analytic_lines/security/ir_rule.xml (+14/-0) trp_external_user_analytic_lines/security/res_groups.xml (+10/-0) trp_external_user_analytic_lines/view/account_analytic_line.xml (+47/-0) trp_external_user_analytic_lines/view/menu.xml (+12/-0) |
| To merge this branch: | bzr merge lp://staging/~therp-nl/therp-addons/6.1-trp_external_user_analytic_lines |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Holger Brunn (Therp) | Disapprove | ||
| Stefan Rijnhart (Opener) (community) | Needs Information | ||
|
Review via email:
|
|||
To post a comment you must log in.
Revision history for this message
| Stefan Rijnhart (Opener) (stefan-opener) wrote | # |
review:
Needs Information
Unmerged revisions
- 106. By Holger Brunn (Therp)
-
[FIX] additional dependencies
- 105. By Holger Brunn (Therp)
-
[ADD] button to open the analytic line's origin
- 104. By Holger Brunn (Therp)
-
[ADD] trp_external_
user_analytic_ lines
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Thanks! Why are older items hidden using the 'to be invoiced' filter in l.271?
In the module description, please mention the nice feature that the related project issues or tasks are accessible from the analytic lines.
(this implicitely explains that there are more dependencies to expect than you would gather if this module did nothing else but extend on permissions on analytic lines. I still miss that apt-get style dialog in Odoo saying 'Installing this module will also install project_issue. Do you want to continue?')