OpenUpgrade Addons

Merge lp://staging/~therp-nl/openupgrade-addons/7.0-wiki-nobacktracking-regex into lp://staging/openupgrade-addons

7.0-wiki-nobacktracking-regex
Merge into 7.0

Proposed by Holger Brunn (Therp) on 2014-10-20

Status:	Merged
Merged at revision:	8174
Proposed branch:	lp://staging/~therp-nl/openupgrade-addons/7.0-wiki-nobacktracking-regex
Merge into:	lp://staging/openupgrade-addons
Diff against target:	55 lines (+32/-8) 1 file modified document_page/migrations/7.0.1.0.1/post-migration.py (+32/-8)
To merge this branch:	bzr merge lp://staging/~therp-nl/openupgrade-addons/7.0-wiki-nobacktracking-regex
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ronald Portier (Therp)	code review and test		Approve on 2014-10-20
Pedro Manuel Baeza	code review		Approve on 2014-10-20
Sandy Carter (http://www.savoirfairelinux.com) (community)	code review, no test	2014-10-20	Approve on 2014-10-20
Review via email: mp+238872@code.staging.launchpad.net

Description of the change

This branch avoids using regexes in cases where backtracking can become so expensive that it seems like a deadlock, i.e. with

re.compile("'''''(([^']|([^']'{0,4}[^']))+)'''''").sub("<b><i>\1</i></b>", "'''''test'''' hello world hello world hello world hello world hello world hello world hello world hello world hello world hello world hello world")

Note that this occurs with all regexes of this kind in the case it's a malformed wiki syntax

Revision history for this message