OpenERP Community Backports (Addons)

Merge lp://staging/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date into lp://staging/ocb-addons

7.0_lp914670_update_picking_date
Merge into 7.0

Proposed by Ronald Portier (Therp) on 2014-06-18

Status:

Merged

Merged at revision:

10206

Proposed branch:

lp://staging/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date

Merge into:

lp://staging/ocb-addons

Diff against target:

56 lines (+33/-4)

1 file modified

stock/stock.py (+33/-4)

To merge this branch:

bzr merge lp://staging/~therp-nl/ocb-addons/7.0_lp914670_update_picking_date

Medium

Confirmed

Link a bug report

Reviewer	Review Type	Date Requested	Status
Pedro Manuel Baeza	code review		Approve on 2014-06-18
Sébastien BEAU - http://www.akretion.com	code review, no test		Approve on 2014-06-18
Raphaël Valyi - http://www.akretion.com		2014-06-18	Approve on 2014-06-18
Review via email: mp+223551@code.staging.launchpad.net

Description of the change

Fixes lp 914670. Expected date on stock.picking should change (be recomputed) when expected date on stock.move changes.

Revision history for this message

Raphaël Valyi - http://www.akretion.com (rvalyi) wrote on 2014-06-18:

LGTM

review: Approve

Revision history for this message

Sébastien BEAU - http://www.akretion.com (sebastien.beau) wrote on 2014-06-18:

Great fix ! Approve

review: Approve (code review, no test)

Revision history for this message

Pedro Manuel Baeza (pedro.baeza) wrote on 2014-06-18:

I see the code more elegant in this way, but it doesn't really matter:

    picking_ids = set()
    for move_obj in move_pool.browse(cr, uid, ids, context=context):
        if move_obj.picking_id:
            picking_ids.add(move_obj.picking_id.id)
    return list(picking_ids)

Regards.

review: Approve (code review)

Revision history for this message

Ronald Portier (Therp) (rportier1962) wrote on 2014-06-18:

Updated merge proposal according to suggestion from Pedro Manual Baeza.

Much better this way!