OpenERP Community Backports (Addons)

Merge lp://staging/~therp-nl/ocb-addons/7.0-aged_partner_balance_selection_of_partners into lp://staging/ocb-addons

  1. 7.0-aged_partner_balance_selection_of_partners
  2. Merge into 7.0
Proposed by Stefan Rijnhart (Opener)
Status: Merged
Merged at revision: 9475
Proposed branch: lp://staging/~therp-nl/ocb-addons/7.0-aged_partner_balance_selection_of_partners
Merge into: lp://staging/ocb-addons
Diff against target: 87 lines (+23/-4)
3 files modified
account/report/account_aged_partner_balance.py (+14/-2)
account/wizard/account_report_aged_partner_balance.py (+2/-2)
account/wizard/account_report_aged_partner_balance_view.xml (+7/-0)
To merge this branch: bzr merge lp://staging/~therp-nl/ocb-addons/7.0-aged_partner_balance_selection_of_partners
Reviewer Review Type Date Requested Status
Holger Brunn (Therp) code review Approve
Guewen Baconnier @ Camptocamp code review, no test Approve
Niels Huylebroeck (community) Approve
Review via email: mp+183608@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Niels Huylebroeck (red15) wrote :

pdb statement in account/report/account_partner_ledger.py

review: Needs Fixing
Revision history for this message
Stefan Rijnhart (Opener) (stefan-opener) wrote :

Hi Niels, you're quick! I caught it myself too.

Revision history for this message
Niels Huylebroeck (red15) wrote :

http://imgur.com/1srzBHJ

Revision history for this message
Niels Huylebroeck (red15) wrote :

Looks ok now, isn't this report also included in the financial reporting by c2c (though in webkit?)

review: Approve
Revision history for this message
Guewen Baconnier @ Camptocamp (gbaconnier-c2c) wrote :

> Looks ok now, isn't this report also included in the financial reporting by
> c2c (though in webkit?)

No, there is no aged partner balance in our reports.

Code seems ok to me

review: Approve (code review, no test)
Revision history for this message
Holger Brunn (Therp) (hbrunn) :
review: Approve (code review)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.