Merge lp://staging/~themuso/unity/present-plaintext-quicklist-menu-items-for-a11y into lp://staging/unity
Proposed by
Luke Yelavich
| Status: | Merged |
|---|---|
| Approved by: | Stephen M. Webb |
| Approved revision: | no longer in the source branch. |
| Merged at revision: | 3664 |
| Proposed branch: | lp://staging/~themuso/unity/present-plaintext-quicklist-menu-items-for-a11y |
| Merge into: | lp://staging/unity |
| Diff against target: |
73 lines (+19/-1) 5 files modified
launcher/ApplicationLauncherIcon.cpp (+1/-0) launcher/QuicklistMenuItem.cpp (+15/-0) launcher/QuicklistMenuItem.h (+1/-0) launcher/VolumeLauncherIcon.cpp (+1/-0) plugins/unityshell/src/unity-quicklist-menu-item-accessible.cpp (+1/-1) |
| To merge this branch: | bzr merge lp://staging/~themuso/unity/present-plaintext-quicklist-menu-items-for-a11y |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Stephen M. Webb (community) | Approve | ||
| PS Jenkins bot (community) | continuous-integration | Approve | |
|
Review via email:
|
|||
Commit message
QuickListMenuItem: Add GetPlainTextLabel method to better present quicklist menu items to screen reader users.
When Orca users navigate quicklists, they hear something like <b>item name</b>, due to the markup for the item being used as the accessible label. Use the ACCESSIBLE_DESC property of dbusmenu menu items to provide a plain text form of the label.
Description of the change
QuickListMenuItem: Add GetPlainTextLabel method to better present quicklist menu items to screen reader users.
When Orca users navigate quicklists, they hear something like <b>item name</b>, due to the markup for the item being used as the accessible label. Use the ACCESSIBLE_DESC property of dbusmenu menu items to provide a plain text form of the label.
To post a comment you must log in.
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Needs Fixing
(continuous-integration)
Revision history for this message
| PS Jenkins bot (ps-jenkins) wrote | # |
review:
Approve
(continuous-integration)
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
FAILED: Continuous integration, rev:3657
http://
Executed test runs:
FAILURE: http://
SUCCESS: http://
FAILURE: http://
Click here to trigger a rebuild:
http://