Unity

Merge lp://staging/~themuso/unity/keep-own-copy-of-quicklist-menu-item-label into lp://staging/unity

  1. keep-own-copy-of-quicklist-menu-item-label
  2. Merge into trunk
Proposed by Luke Yelavich
Status: Merged
Approved by: Marco Trevisan (Treviño)
Approved revision: no longer in the source branch.
Merged at revision: 4010
Proposed branch: lp://staging/~themuso/unity/keep-own-copy-of-quicklist-menu-item-label
Merge into: lp://staging/unity
Diff against target: 69 lines (+21/-7)
1 file modified
plugins/unityshell/src/unity-quicklist-menu-item-accessible.cpp (+21/-7)
To merge this branch: bzr merge lp://staging/~themuso/unity/keep-own-copy-of-quicklist-menu-item-label
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Needs Fixing
Review via email: mp+270774@code.staging.launchpad.net

Commit message

Make a copy of a quicklist menu item plain text label

Likely due to changes in the gcc transition, Orca stopped speaking quicklist menu items. It seems that keeping a separate copy of the label string for a11y use allows quicklist menu items to be spoken again.

Description of the change

Make a copy of a quicklist menu item plain text label

Likely due to changes in the gcc transition, Orca stopped speaking quicklist menu items. It seems that keeping a separate copy of the label string for a11y use allows quicklist menu items to be spoken again.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:4001
http://jenkins.qa.ubuntu.com/job/unity-ci/1293/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-amd64-ci/71/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-armhf-ci/69/console
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-i386-ci/69/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1293/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

+1

review: Approve
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Ouch no.. Approved wrong branch.

There 's a FTB here due to a missing bracket (see inline comment).

Revision history for this message
Marco Trevisan (Treviño) (3v1n0) :
review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

FAILED: Continuous integration, rev:4002
http://jenkins.qa.ubuntu.com/job/unity-ci/1300/
Executed test runs:
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-amd64-ci/78/console
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-wily-armhf-ci/76
    FAILURE: http://jenkins.qa.ubuntu.com/job/unity-wily-i386-ci/76/console

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/1300/rebuild

review: Needs Fixing (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

Thanks.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.