Unity

Merge lp://staging/~themuso/unity/improve-shutdown-dialog-a11y into lp://staging/unity

  1. improve-shutdown-dialog-a11y
  2. Merge into trunk
Proposed by Luke Yelavich
Status: Merged
Approved by: Stephen M. Webb
Approved revision: no longer in the source branch.
Merged at revision: 3698
Proposed branch: lp://staging/~themuso/unity/improve-shutdown-dialog-a11y
Merge into: lp://staging/unity
Diff against target: 381 lines (+324/-0)
4 files modified
plugins/unityshell/src/nux-layout-accessible.cpp (+5/-0)
plugins/unityshell/src/unity-session-button-accessible.cpp (+260/-0)
plugins/unityshell/src/unity-session-button-accessible.h (+53/-0)
plugins/unityshell/src/unitya11y.cpp (+6/-0)
To merge this branch: bzr merge lp://staging/~themuso/unity/improve-shutdown-dialog-a11y
Reviewer Review Type Date Requested Status
Marco Trevisan (Treviño) Approve
PS Jenkins bot (community) continuous-integration Approve
Review via email: mp+207089@code.staging.launchpad.net

Commit message

Implement accessibility for the optino buttons in the shutdown dialog.

Also improve the parent-child relationship between objects such that the shutdown message can be read with Orca flat review.

Description of the change

Implement accessibility for the optino buttons in the shutdown dialog.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3670
http://jenkins.qa.ubuntu.com/job/unity-ci/685/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/221
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/217
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/219

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/685/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

412 + highlight_change.emit();

424 + sigc::signal<void> highlight_change;

You don't need that, I'm using a nux::Property for highlighted, and it already supports signaling.

Just connect to highlighted.changed signal ;)

review: Needs Fixing
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:3672
http://jenkins.qa.ubuntu.com/job/unity-ci/707/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-amd64-ci/243
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-armhf-ci/239
    SUCCESS: http://jenkins.qa.ubuntu.com/job/unity-trusty-i386-ci/241

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/unity-ci/707/rebuild

review: Approve (continuous-integration)
Revision history for this message
Marco Trevisan (Treviño) (3v1n0) wrote :

376 + if (object->Type().IsDerivedFromType(Button::StaticObjectType))
377 + return unity_session_button_accessible_new(object);

It shuold work anyway, but I think it's better to use IsDerivedFromType(session::Button::StaticObjectType), to avoid future conflicts.

Anyway this looks good now, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.