DBus Menu

Merge lp://staging/~themuso/libdbusmenu/violate-atk-docs-again into lp://staging/libdbusmenu/0.6

  1. violate-atk-docs-again
  2. Merge into trunk.0.6
Proposed by Luke Yelavich
Status: Merged
Merged at revision: 383
Proposed branch: lp://staging/~themuso/libdbusmenu/violate-atk-docs-again
Merge into: lp://staging/libdbusmenu/0.6
Diff against target: 17 lines (+5/-1)
1 file modified
libdbusmenu-gtk/client.c (+5/-1)
To merge this branch: bzr merge lp://staging/~themuso/libdbusmenu/violate-atk-docs-again
Reviewer Review Type Date Requested Status
Ted Gould (community) Approve
Luke Yelavich (community) Abstain
Review via email: mp+93525@code.staging.launchpad.net

Description of the change

Do not set the accessible name to an empty string if the accessible_desc
  property = NULL. Yes this was recently changed so that dbusmenu conformed
  to Atk documentation, but the GTK menu item accessibility code does not yet
  conform to sed documentation. As a result, all dbusmenu menu items that do not
  have the accessible_desc property set end up getting an empty string for their
  accessible name. In the long term, GTK accessibility needs to be fixed.

To post a comment you must log in.
Revision history for this message
Ted Gould (ted) wrote :

On Fri, 2012-02-17 at 04:26 +0000, Luke Yelavich wrote:
> Do not set the accessible name to an empty string if the accessible_desc
> property = NULL. Yes this was recently changed so that dbusmenu conformed
> to Atk documentation, but the GTK menu item accessibility code does not yet
> conform to sed documentation. As a result, all dbusmenu menu items that do not
> have the accessible_desc property set end up getting an empty string for their
> accessible name. In the long term, GTK accessibility needs to be fixed.

Uhg, frustrating that's the case. Do you know of a link to a bug in the
GTK stack that we could put in a comment just to know why we did
this? :-)

Revision history for this message
Luke Yelavich (themuso) wrote :

After a recent update, things have mysteriously started working again. I'll keep a look out to see if things break again, and will keep this branch on hold, but it doesn't appear to be needed for now.

review: Abstain
Revision history for this message
Luke Yelavich (themuso) wrote :

Turns out I had a locally built copy with the fix in it. There is no GTK bug yet, but I will file one, as soon as I finish bisecting GTK to find a commit that broke some GtkViewColumn code when accessibility is enabled, since I'll have to file a bug for that too...

Revision history for this message
Ted Gould (ted) :
review: Approve
Revision history for this message
Ted Gould (ted) wrote :

Hmm, when running the test suite we get errors on setting it to NULL:

** CRITICAL **: atk_object_set_name: assertion `name != NULL' failed

review: Needs Fixing
Revision history for this message
Ted Gould (ted) wrote :

Okay, that works.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: