Merge lp://staging/~themuso/libdbusmenu/add-accessible-desc-property into lp://staging/libdbusmenu/0.6
Proposed by
Luke Yelavich
| Status: | Merged |
|---|---|
| Approved by: | Ted Gould |
| Approved revision: | 348 |
| Merged at revision: | 358 |
| Proposed branch: | lp://staging/~themuso/libdbusmenu/add-accessible-desc-property |
| Merge into: | lp://staging/libdbusmenu/0.6 |
| Diff against target: |
106 lines (+23/-1) 5 files modified
configure.ac (+2/-0) libdbusmenu-glib/client.c (+2/-1) libdbusmenu-glib/defaults.c (+1/-0) libdbusmenu-glib/menuitem.h (+12/-0) libdbusmenu-gtk/client.c (+6/-0) |
| To merge this branch: | bzr merge lp://staging/~themuso/libdbusmenu/add-accessible-desc-property |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Ted Gould (community) | Approve | ||
| DBus Menu Team | Pending | ||
|
Review via email:
|
|||
Description of the change
THe code in this branch builds and does work at a technical level, but the desired alternative labels for menu items won't be properly read with orca unless either GTK3 version 3.2.2-2ubuntu4 or GTK2 version 2.24.8-0ubuntu5 are installed, as I had to extend the accessible objects in GTK to allow dbusmenu to set a different accessible name.
I hope to get the GTK code changes upstream ASAP, hopefully for GTK 3.4, but if not, then future GTK releases.
To post a comment you must log in.
Revision history for this message
| Luke Yelavich (themuso) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
Ok, turns out that this does not need any changes in GTK, GTK supports this natively.