Application Menu Indicator

Merge lp://staging/~themuso/indicator-appmenu/accessible-desc into lp://staging/indicator-appmenu/0.3

accessible-desc
Merge into trunk

Proposed by Luke Yelavich on 2011-02-15

Status:	Merged
Merged at revision:	105
Proposed branch:	lp://staging/~themuso/indicator-appmenu/accessible-desc
Merge into:	lp://staging/indicator-appmenu/0.3
Diff against target:	31 lines (+7/-0) 1 file modified src/window-menus.c (+7/-0)
To merge this branch:	bzr merge lp://staging/~themuso/indicator-appmenu/accessible-desc
Related bugs:	Link a bug report

Reviewer	Review Type	Date Requested	Status
Ted Gould (community)		2011-02-15	Needs Fixing on 2011-02-16
Review via email: mp+49748@code.staging.launchpad.net

Revision history for this message

Ted Gould (ted) wrote on 2011-02-16:

There also needs to be code in menu_prop_changed() so that when the
label changes the accessible label also gets updated.

review needsfixing

review: Needs Fixing

lp://staging/~themuso/indicator-appmenu/accessible-desc updated on 2011-02-16

106. By Luke Yelavich on 2011-02-16: Also update the accessible description in menu_prop_changed, although I am
not sure how we can signal a change from here.

Revision history for this message

Luke Yelavich (themuso) wrote on 2011-02-16:

On Thu, Feb 17, 2011 at 09:26:16AM EST, Ted Gould wrote:
> Review: Needs Fixing
> There also needs to be code in menu_prop_changed() so that when the
> label changes the accessible label also gets updated.

Ok, I updated the accessible_desc in that function, however I am not sure how I can signal a change from there, given I need a pointer to the indicator object for that indicator.