Online Accounts: GNOME Control Center

Merge lp://staging/~themuso/gnome-control-center-signon/add-a11y-label-associations into lp://staging/gnome-control-center-signon

  1. add-a11y-label-associations
  2. Merge into trunk
Proposed by Luke Yelavich
Status: Needs review
Proposed branch: lp://staging/~themuso/gnome-control-center-signon/add-a11y-label-associations
Merge into: lp://staging/gnome-control-center-signon
Diff against target: 12 lines (+2/-0)
1 file modified
src/cc-credentials-providers-page.vala (+2/-0)
To merge this branch: bzr merge lp://staging/~themuso/gnome-control-center-signon/add-a11y-label-associations
Reviewer Review Type Date Requested Status
PS Jenkins bot (community) continuous-integration Approve
Alberto Mardegan (community) Needs Fixing
Review via email: mp+208267@code.staging.launchpad.net

Commit message

Add a11y label associations.

Description of the change

Add a11y label associations.

To post a comment you must log in.
Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:177
http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-ci/20/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-trusty-amd64-ci/5
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-trusty-armhf-ci/3
        deb: http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-trusty-armhf-ci/3/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gnome-control-center-signon-ci/20/rebuild

review: Approve (continuous-integration)
Reply
Revision history for this message
Alberto Mardegan (mardy) wrote :

Thanks Luke! Just a minor nitpick: can you please split the line, maybe at the comma?

review: Needs Fixing
Reply
lp://staging/~themuso/gnome-control-center-signon/add-a11y-label-associations updated
178. By Luke Yelavich

Split add_relationship call over 2 lines to improve readability.

Revision history for this message
PS Jenkins bot (ps-jenkins) wrote :

PASSED: Continuous integration, rev:178
http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-ci/21/
Executed test runs:
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-trusty-amd64-ci/6
    SUCCESS: http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-trusty-armhf-ci/4
        deb: http://jenkins.qa.ubuntu.com/job/gnome-control-center-signon-trusty-armhf-ci/4/artifact/work/output/*zip*/output.zip

Click here to trigger a rebuild:
http://s-jenkins.ubuntu-ci:8080/job/gnome-control-center-signon-ci/21/rebuild

review: Approve (continuous-integration)
Reply

Unmerged revisions

178. By Luke Yelavich

Split add_relationship call over 2 lines to improve readability.

177. By Luke Yelavich

Add a11y label associations.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: