lp://staging/~themue/juju-core/go-state-first-error-improvement

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://staging/~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-06-11

Diff: 812 lines (+163/-110)

10 files modified

state/internal_test.go (+10/-10)
state/machine.go (+2/-2)
state/relation.go (+19/-1)
state/service.go (+4/-4)
state/state.go (+8/-11)
state/state_test.go (+4/-4)
state/topology.go (+43/-54)
state/unit.go (+17/-12)
state/util.go (+55/-11)
state/watcher_test.go (+1/-1)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

214. By Frank Mueller on 2012-06-11

state: First proposal for an improvement of the error handling in state.

213. By Roger Peppe on 2012-06-07

state: store units inside their respective services

Making this change simplifies a lot of code - no need
to keep a separate sequence numbering system for units,
for example.

(original proposal at https://codereview.appspot.com/6247066/)

R=
CC=
https://codereview.appspot.com/6300060

212. By Gustavo Niemeyer on 2012-06-06

.lbox: update to juju-core

211. By Gustavo Niemeyer on 2012-06-06

Translated all paths to use the juju-core project in Launchpad.

210. By Frank Mueller on 2012-06-06

state: Changed relation service mapping in topology.

The first approach mapped roles to service key and relation
name opposite to todays Python implementation. This reduces
the flexibility for future purposes (e.g. multiple peers).
So the mapping has now been changed back from service keys
to relation role and name.

R=
CC=
https://codereview.appspot.com/6268049

209. By Gustavo Niemeyer on 2012-06-06

state: rename Environment method to EnvironConfig

R=TheMue, fwereade
CC=
https://codereview.appspot.com/6295048

208. By William Reade on 2012-06-06

subordinate service units can now be added to principal service units

This entails the following changes:

* new Service.AddUnitSubordinateTo method, which requires a principal unit
* topology.AddUnit now takes an additional principalKey string argument,
  which will be empty for a principal unit;
* new topology.UnitPrincipalKey, which returns the principal unit key for a
  subordinate unit or an error for a principal unit;
* new Unit.IsPrincipal method, which returns whether the unit is a principal
  unit;
* checks to prevent subordinate units being assigned directly to machines.

Most of the diff lines are a result of the change to topology.AddUnit;
sorry for the noise.

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6268050

207. By Frank Mueller on 2012-06-06

state: Added the method RemoveRelation() to State.

Relation is now an interface defining the single
method relationKey() to allow a function signature
like today in Python. The implementation is now
named relation and can be accessed via type
assertion.

R=niemeyer
CC=
https://codereview.appspot.com/6250076

206. By William Reade on 2012-06-06

trivial: fix inconsistency in deploy command documentation

R=
CC=
https://codereview.appspot.com/6304045

205. By William Reade on 2012-06-06

add AssignmentPolicy to Environ

This is very likely to migrate to a Settings type at some stage, but I don't
think that's justified yet.

R=niemeyer
CC=
https://codereview.appspot.com/6259062