lp://staging/~themue/juju-core/go-firewaller-global-mode

Branch merges

Propose for merging

No branches dependent on this one.

Rejected for merging into lp://staging/~juju/juju-core/trunk

The Go Language Gophers: Pending requested 2012-10-08

Diff: 269 lines (+148/-10)

3 files modified

environs/dummy/environs.go (+45/-10)
worker/firewaller/firewaller.go (+31/-0)
worker/firewaller/firewaller_test.go (+72/-0)

api

Related source package recipes

No recipes using this branch. (?)

Create packaging recipe

Related snap packages

Related bugs

Related blueprints

628. By Frank Mueller on 2012-10-08

firewaller: added port counter for global mode

627. By Roger Peppe on 2012-10-05

trivial: add PasswordHash and RandomBytes

R=niemeyer
CC=
https://codereview.appspot.com/6615047

626. By Roger Peppe on 2012-10-05

cmd/jujud: make bootstrap-state accept password

This makes bootstrap-state accept all the same flags
as the agents (including --data-dir which it doesn't use;
but it seems to me that it may well use it in the future).

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6623047

625. By Roger Peppe on 2012-10-05

state: make SetAdminPassword("") idempotent

R=TheMue, niemeyer
CC=
https://codereview.appspot.com/6622047

624. By Frank Mueller on 2012-10-05

ec2: integrated firewall mode configuration

After the adding of a configuration switch for default
or global firewall mode this behavior is now integrated
in EC2. If the mode is "global", then instead of a group
per machine one group "juju-<name>-global" is created
additionally to the juju group. All machines share this
global group then and opening and closing ports on it
so effect all machines.

R=niemeyer
CC=
https://codereview.appspot.com/6589073

623. By Dave Cheney on 2012-10-05

cmd: add tests for --format=nnn

Add checks for --format=nnn flag parsing.

This will break for people who have not updated gnuflag to the latest version, this is a good thing.

R=fwereade, niemeyer
CC=
https://codereview.appspot.com/6601056

622. By William Reade on 2012-10-04

uniter: integrate filter type

By tweaking the filter slightly, to provide more carefully-tailored events,
the uniter Modes have been radically simplified.

Note that state.Unit was previously mis-specified, and is now fixed: it's
fine (in fact, potentially necessary) to resolve errors when the unit is
Dying.

Also note that there are roughly 50% more full Uniter tests than the
previous branch, but they run in roughly the same amount of time. Win!
But! This is actually a significant slowdown, because I fixed a bunch of
happy-path 500ms waits in the uniter tests. It's true that this variant does
more unnecessary work in the service of simpler Mode code, and I haven't been
able to find any obvious hotspots (apart from the pre-existing one) so if
reviewers would bear subtle performance implications in mind I would be most
grateful :).

R=rog, niemeyer
CC=
https://codereview.appspot.com/6588053

621. By Dave Cheney on 2012-10-04

cmd/jujuc: config-get: return default values

As discussed on IRC, this proposal is not the solution to the complex issue of versioned configuration settings. It is not even a start. However with this patch in place I am able to get charms running on ec2 and fix integration issues.

R=niemeyer
CC=
https://codereview.appspot.com/6591080

620. By William Reade on 2012-10-04

jujuc: move from cmd/jujuc/server

as discussed on IRC

R=niemeyer
CC=
https://codereview.appspot.com/6607043

619. By Roger Peppe on 2012-10-04

environs/config: add admin-secret attribute

R=niemeyer
CC=
https://codereview.appspot.com/6587085