Code review comment for lp://staging/~themue/juju-core/055-apiserver-heartbeat-analyzing

Reviewers: mp+194862_code.launchpad.net,

Message:
Please take a look.

Description:
apiserver: analyzing ping timeouts

This is a first fix of #1205451 handling externally
killed juju nodes. Currently the pings of clients to
the API server are not analyzed. With this change
each ping leads to the reset of a timer waiting for
3 minutes. If it is not reset (by the ping) the timer
signal tells the pinger to kill the connection.

The overall problem with the presence pinger,
especially regarding to HA environments, is not
covered by this change.

https://code.launchpad.net/~themue/juju-core/055-apiserver-heartbeat-analyzing/+merge/194862

(do not edit description out of merge proposal)

Please review this at https://codereview.appspot.com/24040044/

Affected files (+114, -8 lines):
   A [revision details]
   M state/apiserver/export_test.go
   M state/apiserver/root.go
   M state/apiserver/root_test.go