Charm Helpers

Merge lp://staging/~thedac/charm-helpers/haproxy-options into lp://staging/charm-helpers

  1. haproxy-options
  2. Merge into devel
Proposed by David Ames
Status: Merged
Merged at revision: 730
Proposed branch: lp://staging/~thedac/charm-helpers/haproxy-options
Merge into: lp://staging/charm-helpers
Diff against target: 19 lines (+9/-0)
1 file modified
charmhelpers/contrib/openstack/templates/haproxy.cfg (+9/-0)
To merge this branch: bzr merge lp://staging/~thedac/charm-helpers/haproxy-options
Reviewer Review Type Date Requested Status
Billy Olsen Approve
charmers Pending
Review via email: mp+321390@code.staging.launchpad.net

Description of the change

Allow for backend haproxy options

To post a comment you must log in.
Revision history for this message
Billy Olsen (billy-olsen) wrote :

LGTM

review: Approve
Revision history for this message
Billy Olsen (billy-olsen) wrote :

I'm also curious if any of the services may need to set something which is not an option? For instance, the retries count may need to be specified differently for different backends but the syntax is not "option retries", it is instead "retries <count>" so the backend couldn't tune it as necessary.

Revision history for this message
David Ames (thedac) wrote :

Good point. I'll rearrange that.

lp://staging/~thedac/charm-helpers/haproxy-options updated
729. By David Ames

Allow for non 'option' options

Revision history for this message
Billy Olsen (billy-olsen) wrote :

Okay, really LGTM this time.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches