Merge lp://staging/~terrycojones/txamqp/lots-of-comments into lp://staging/txamqp
Proposed by
Terry Jones
| Status: | Approved |
|---|---|
| Approved by: | Thomas Herve |
| Approved revision: | 43 |
| Proposed branch: | lp://staging/~terrycojones/txamqp/lots-of-comments |
| Merge into: | lp://staging/txamqp |
| Diff against target: |
830 lines (+305/-101) 17 files modified
doc/README (+29/-20) setup.py (+3/-1) src/examples/simple/README (+5/-1) src/examples/simple/txconsumer.py (+31/-15) src/examples/simple/txpublisher.py (+40/-26) src/examples/thrift/README (+25/-19) src/txamqp/client.py (+19/-1) src/txamqp/codec.py (+2/-0) src/txamqp/connection.py (+2/-0) src/txamqp/content.py (+2/-0) src/txamqp/delegate.py (+22/-1) src/txamqp/message.py (+2/-0) src/txamqp/protocol.py (+115/-16) src/txamqp/queue.py (+2/-1) src/txamqp/spec.py (+2/-0) src/txamqp/testlib.py (+2/-0) src/txamqp/xmlutil.py (+2/-0) |
| To merge this branch: | bzr merge lp://staging/~terrycojones/txamqp/lots-of-comments |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Thomas Herve | Approve | ||
|
Review via email:
|
|||
Description of the change
This branch is aimed at making the txAMQP code base easier for people to understand. The changes are almost all docstrings, comments, README clarifications, and some cleaning / simplification of the src/examples/simple code.
To post a comment you must log in.
Unmerged revisions
- 43. By Terry Jones
-
Make sure the reactor is running when we go to stop it.
- 42. By Terry Jones
-
Added code to print a friendly message on failure to authenticate with the broker.
- 41. By Terry Jones
-
Simplified the simple example publisher code.
- 40. By Terry Jones
-
Added a bunch of comments to try to help people (mainly me, to start with) understand what's going on.
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
[1] The link to the blog post is broken, mainly you should remove it.
[2]
+ $ bzr branch lp:txamqp txamqp
"bzr branch lp:txamqp" is enough to work.
[3]
+ - path_to_spec: The path to the AMQP spec that you want to use. Note
+ that depending on the broker you use, you will need a
+ different spec:
+ RabbitMQ 1.5.3: $TXAMQP_
I think this path changed.
[4]
-# coding: utf-8
+# -*- coding: utf-8; -*-
We don't really need those as the files are pure ASCII afaict.
[5]
+ """A class that acts like an event that can be fired (via set). This is
+ """Call the init method (if any) in all superclasses of the subclass of
Can you break the line at the beginning?
[6]
+ the delegate (see TwistedDelegate in client.py) to make the appropriate
+ method call."""
And at the end? :)
[7] There are a bunch of conflicts, mostly trivial.
Thanks, +1!