Tickery

Merge lp://staging/~terrycojones/tickery/run-from-top-level-800453 into lp://staging/tickery

  1. run-from-top-level-800453
  2. Merge into trunk
Proposed by Terry Jones
Status: Merged
Approved by: Jamu Kakar
Approved revision: 13
Merged at revision: 13
Proposed branch: lp://staging/~terrycojones/tickery/run-from-top-level-800453
Merge into: lp://staging/tickery
Diff against target: 17 lines (+2/-2)
1 file modified
twisted/plugins/tickery_service.py (+2/-2)
To merge this branch: bzr merge lp://staging/~terrycojones/tickery/run-from-top-level-800453
Reviewer Review Type Date Requested Status
Jamu Kakar Approve
Esteve Fernandez Approve
Review via email: mp+65429@code.staging.launchpad.net

Description of the change

This is a trivial change to the Twisted plugin so it can be invoked
from the top of our source tree.

To post a comment you must log in.
Revision history for this message
Esteve Fernandez (esteve) wrote :

Does this mean we can run tickery without messing withe PYTHONPATH? i.e. no more PYTHONPATH=.. twistd tickery?

review: Needs Information
Revision history for this message
Terry Jones (terrycojones) wrote :

> Does this mean we can run tickery without messing withe PYTHONPATH? i.e. no
> more PYTHONPATH=.. twistd tickery?

Yes.

Revision history for this message
Esteve Fernandez (esteve) wrote :

> > Does this mean we can run tickery without messing withe PYTHONPATH? i.e. no
> > more PYTHONPATH=.. twistd tickery?
>
> Yes.

Thanks for your answer! And sorry for the slow reply.

+1 LGTM

review: Approve
Revision history for this message
Jamu Kakar (jkakar) wrote :

Nice one, +1!

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: