Ubuntu on EC2

Merge lp://staging/~tellis/ubuntu-on-ec2/attach-volume into lp://staging/~ubuntu-on-ec2/ubuntu-on-ec2/cloud-utils

attach-volume
Merge into cloud-utils

Proposed by Tom Ellis on 2011-02-13

Status:	Merged
Merged at revision:	86
Proposed branch:	lp://staging/~tellis/ubuntu-on-ec2/attach-volume
Merge into:	lp://staging/~ubuntu-on-ec2/ubuntu-on-ec2/cloud-utils
Diff against target:	71 lines (+40/-0) 1 file modified uec-run-instances (+40/-0)
To merge this branch:	bzr merge lp://staging/~tellis/ubuntu-on-ec2/attach-volume
Related bugs:	Link a bug report

Reviewer	Date Requested	Status
Tom Ellis (community)		Needs Resubmitting on 2011-02-16
Scott Moser	2011-02-13	Pending
Review via email: mp+49576@code.staging.launchpad.net

Description of the change

Attach volume on boot of system. This work is based on the associate ip and wait_for=ssh work, as volumes can only be attached successfully when instance status = running.
Tested on UEC, might need some tweaking for volume device on ec2.

My first foray into python so be gentle :-)

Revision history for this message

Scott Moser (smoser) wrote on 2011-02-14:

Thanks for doing this. I have two suggestions:
- make default dev (/dev/sdb) configurable via command line options (maybe '--attach-volume-dev). Its fine to use /dev/sdb by default as on ec2, people would probably use --block-device-mapping.
- support attaching a snapshot. I think with the end goal of EBS root, this is more reasonable. Ie, if the target of --attach-volume starts with SNAP- or 'snap-' the, create a volume from that SNAP, wait for it to become available, and then start the instances.

Revision history for this message

Tom Ellis (tellis) wrote on 2011-02-15:

Thanks for the comments Scott, I'll work on updating the patch to add these two features.

lp://staging/~tellis/ubuntu-on-ec2/attach-volume updated on 2011-02-16

86. By Scott Moser on 2011-02-16: add --attach-volume from Tom Ellis

Revision history for this message

Scott Moser (smoser) wrote on 2011-02-16:

I merged.
Tom just work on the other two changes and submit those.

Revision history for this message

Tom Ellis (tellis) wrote on 2011-02-16:

Checked out the branch after your merge and noticed a problem with an indent causing it traceback. Fixed it in this merge, not sure how that got in there...

Working on those other proposals and will submit other merge requests.

Cheers!

review: Needs Resubmitting