Switchboard About Plug

Merge lp://staging/~teemperor/switchboard-plug-about/storage-dmesg-change into lp://staging/~elementary-apps/switchboard-plug-about/trunk

  1. storage-dmesg-change
  2. Merge into trunk
Proposed by Raphael Isemann
Status: Rejected
Rejected by: kay van der Zander
Proposed branch: lp://staging/~teemperor/switchboard-plug-about/storage-dmesg-change
Merge into: lp://staging/~elementary-apps/switchboard-plug-about/trunk
Diff against target: 82 lines (+20/-19)
1 file modified
src/about-plug.vala (+20/-19)
To merge this branch: bzr merge lp://staging/~teemperor/switchboard-plug-about/storage-dmesg-change
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Fixing
Review via email: mp+165822@code.staging.launchpad.net
To post a comment you must log in.
Revision history for this message
Raphael Isemann (teemperor) wrote :

Forgot to add a description:

dmesg to get the available storage without su-rights. Also i renamed the hdd_* variables to storage_* variables to fit the translation change we had lately.

Revision history for this message
Pim Vullers (pimvullers) wrote :

Looks good, this should fix part of bug #1182396. Cannot test it due to not reaching that point in code (fails when getting graphics details):
** (about:9990): CRITICAL **: file /tmp/portage/pantheon-base/switchboard-plug-about-9999/work/switchboard-plug-about-9999_build/src/about-plug.c: line 731: uncaught error: Failed to execute child process "lspci" (No such file or directory) (g-exec-error-quark, 8)

Revision history for this message
Cody Garver (codygarver) wrote :

Only solves half of the bug.

review: Needs Fixing

Unmerged revisions

99. By Raphael Isemann

Replace df for storage size with a workaround via dmesg

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches

to all changes: