Merge lp://staging/~teemperor/pantheon-terminal/unique-terminal-id-actual into lp://staging/~elementary-apps/pantheon-terminal/trunk
Proposed by
Raphael Isemann
| Status: | Merged | ||||
|---|---|---|---|---|---|
| Approved by: | Sergey "Shnatsel" Davidoff | ||||
| Approved revision: | 590 | ||||
| Merged at revision: | 590 | ||||
| Proposed branch: | lp://staging/~teemperor/pantheon-terminal/unique-terminal-id-actual | ||||
| Merge into: | lp://staging/~elementary-apps/pantheon-terminal/trunk | ||||
| Diff against target: |
21 lines (+2/-2) 1 file modified
src/TerminalWidget.vala (+2/-2) |
||||
| To merge this branch: | bzr merge lp://staging/~teemperor/pantheon-terminal/unique-terminal-id-actual | ||||
| Related bugs: |
|
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Sergey "Shnatsel" Davidoff (community) | Approve | ||
|
Review via email:
|
|||
Commit message
Use a tab counter instead of a random number for terminal_id. This guarantees that terminal_id will be unique during life-time of the terminal (unless the user creates so many tabs that they overflow the int).
Description of the change
See the bug-report
To post a comment you must log in.
Revision history for this message
| Sergey "Shnatsel" Davidoff (shnatsel) wrote | # |
Preview Diff
[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
xapantu says the constructor will never be called in parallel, so the access to the variable is as good as atomic.