Merge lp://staging/~teemperor/pantheon-terminal/top-margin into lp://staging/~elementary-apps/pantheon-terminal/trunk

Proposed by Raphael Isemann
Status: Merged
Approved by: David Gomes
Approved revision: 386
Merge reported by: David Gomes
Merged at revision: not available
Proposed branch: lp://staging/~teemperor/pantheon-terminal/top-margin
Merge into: lp://staging/~elementary-apps/pantheon-terminal/trunk
Diff against target: 19 lines (+1/-1)
1 file modified
src/PantheonTerminalWindow.vala (+1/-1)
To merge this branch: bzr merge lp://staging/~teemperor/pantheon-terminal/top-margin
Reviewer Review Type Date Requested Status
David Gomes (community) Approve
Review via email: mp+134122@code.staging.launchpad.net

Description of the change

Added 3px margin to the notebook

To post a comment you must log in.
Revision history for this message
David Gomes (davidgomes) wrote :

First of all, there's always 1 space before and after an equal '=' sign.

Secondly, I'd rather this change was made on line 145 (after or before setting show_icons) because that's where we define appearance-related settings of the notebook.

review: Needs Fixing
386. By Raphael Isemann

corrections for review

Revision history for this message
David Gomes (davidgomes) :
review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches