Merge lp://staging/~teemperor/pantheon-greeter/without-gl into lp://staging/~elementary-pantheon/pantheon-greeter/trunk

Proposed by Raphael Isemann
Status: Rejected
Rejected by: Cody Garver
Proposed branch: lp://staging/~teemperor/pantheon-greeter/without-gl
Merge into: lp://staging/~elementary-pantheon/pantheon-greeter/trunk
Diff against target: 68 lines (+1/-27)
3 files modified
CMakeLists.txt (+0/-1)
src/Wallpaper.vala (+1/-9)
vapi/gl.vapi (+0/-17)
To merge this branch: bzr merge lp://staging/~teemperor/pantheon-greeter/without-gl
Reviewer Review Type Date Requested Status
Cody Garver (community) Needs Information
Review via email: mp+192783@code.staging.launchpad.net

Description of the change

I think we can merge this branch without issues. Please test some bigger wallpaper with this branch.

To post a comment you must log in.
Revision history for this message
Cody Garver (codygarver) wrote :

Wasn't there a bug involving gl where if the wallpaper was too large, it made a black background? I seem to remember gl being the fix for that. If that's accurate, how would this handle a huge wallpaper?

review: Needs Information
Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Either experimental or very latest Clutter can tile textures to be able to process images bigger than the hardware allows natively. However, last time I checked this feature was under experimental API, which means that you might need to change some Clutter API calls.

If such functionality in Clutter still isn't stable and is not going to be stable by 14.04, we're probably better off with developing an OpenGL ES codepath equivalent to the current OpenGL one.

Unmerged revisions

214. By Raphael Isemann

removed gl dep for arm-testing

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches