Merge lp://staging/~teemperor/pantheon-greeter/slide-away-ui into lp://staging/~elementary-pantheon/pantheon-greeter/trunk

Proposed by Raphael Isemann
Status: Rejected
Rejected by: Raphael Isemann
Proposed branch: lp://staging/~teemperor/pantheon-greeter/slide-away-ui
Merge into: lp://staging/~elementary-pantheon/pantheon-greeter/trunk
Diff against target: 61 lines (+18/-15)
1 file modified
src/PantheonGreeter.vala (+18/-15)
To merge this branch: bzr merge lp://staging/~teemperor/pantheon-greeter/slide-away-ui
Reviewer Review Type Date Requested Status
elementary UX Pending
elementary Pantheon team Pending
Review via email: mp+192781@code.staging.launchpad.net

Commit message

Slide away the UI on login.

Description of the change

We slide the UI away that only the wallpaper is visible. Just a first step towards a smooth login transition.

I need a review about the design and the code for merging it :)

To post a comment you must log in.
Revision history for this message
Danielle Foré (danrabbit) wrote :

I'm not a huge fan of the login box and clock sliding away. I think it would be better if they used the same animation as a window closing. But overall, it's an improvement to have some kind of animation here.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

Actually it might not be an improvement because the animation is rather long (in time) and will end abruptly in case of fast login. This will not look good.

I would prefer a shorter animation where the clock and login box slide out in different directions but fade out quickly, before they leave the screen. This would look as if they're revealing the desktop, which I believe was your original intention, but will be much shorter.

I'm not a fan of using the window closing animation here, it doesn't give the sence of entering your workspace or anything like that, it feels like just some annoying boxes getting out of your way.

Revision history for this message
Sergey "Shnatsel" Davidoff (shnatsel) wrote :

My assumption about animation ending abruptly was wrong - turns out the greeter completes the animation first and then initiates the user session. So the login will always be delayed by the length of the animation, 600ms in this case, which IMO is unacceptable. If we choose to implement animation at all, it should be no longer than 200ms.

Unmerged revisions

225. By Raphael Isemann

added missing loginbox animation

224. By Raphael Isemann

fixed animation and added sliding for time-label

223. By Raphael Isemann

first version of sliding the ui-elements away

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
The diff is not available at this time. You can reload the page or download it.

Subscribers

People subscribed via source and target branches