Greeter

Merge lp://staging/~teemperor/pantheon-greeter/prevent-accidential-launch into lp://staging/~elementary-pantheon/pantheon-greeter/trunk

prevent-accidential-launch
Merge into trunk

Proposed by Raphael Isemann on 2014-08-04

Status:

Rejected

Rejected by:

Raphael Isemann on 2014-10-08

Proposed branch:

lp://staging/~teemperor/pantheon-greeter/prevent-accidential-launch

Merge into:

lp://staging/~elementary-pantheon/pantheon-greeter/trunk

Prerequisite:

lp://staging/~teemperor/pantheon-greeter/wallpaper-settings-from-file

Diff against target:

17 lines (+7/-0)

1 file modified

src/PantheonGreeter.vala (+7/-0)

To merge this branch:

bzr merge lp://staging/~teemperor/pantheon-greeter/prevent-accidential-launch

Medium

Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
elementary Pantheon team		2014-08-04	Pending
Review via email: mp+229531@code.staging.launchpad.net

This proposal supersedes a proposal from 2014-08-04.

Description of the change

Not much to say here.
After pantheon-greeter is now in PATH we should do this to prevent even more harm to the human population...

Revision history for this message

Cameron Norman (cameronnemo) wrote on 2014-08-09:

The lightdm user may be changed to _lightdm or _ldm or something else by a distribution, or maybe LightDM even runs as root because of a distribution specific. You can check if LIGHTDM_TO_SERVER_FD is set to see if we were launched by LightDM, and it looks like pantheon-greeter *already* checks if it is set, and simply warns instead of errors out:

** (pantheon-greeter:24061): WARNING **: No LIGHTDM_TO_SERVER_FD environment variable

Perhaps just changing that to an error (unless --force-launch is used) would work.

Revision history for this message

Raphael Isemann (teemperor) wrote on 2014-10-08:

Thanks for the input and you are right, LIGHTDM_TO_SERVER_FD should be used. I added a test-mode to this branch (which is now using a dummy-backend instead of talking to lightdm):
https://code.launchpad.net/~teemperor/pantheon-greeter/fix-login/+merge/237689

On a side node, the warning-message is coming from lightdm and not from pantheon-greeter.

Also, this branch is superseded through the branch mentioned above.

Unmerged revisions

277. By Raphael Isemann on 2014-08-04: We prevent the user from launching this by accident from the shell
276. By Raphael Isemann on 2014-08-04: We now read the wallpaper from a .greeter-settings file