Greeter

Merge lp://staging/~teemperor/pantheon-greeter/fix-login into lp://staging/~elementary-pantheon/pantheon-greeter/trunk

fix-login
Merge into trunk

Proposed by Raphael Isemann on 2014-10-08

Status:

Merged

Approved by:

Raphael Isemann on 2014-10-21

Approved revision:

299

Merged at revision:

320

Proposed branch:

lp://staging/~teemperor/pantheon-greeter/fix-login

Merge into:

lp://staging/~elementary-pantheon/pantheon-greeter/trunk

Diff against target:

1814 lines (+959/-418)

10 files modified

src/Authenticator.vala (+318/-0)
src/Avatar.vala (+2/-2)
src/CredentialsArea.vala (+30/-95)
src/Indicators/Indicators.vala (+3/-3)
src/Indicators/KeyboardLayoutMenu.vala (+17/-12)
src/LoginBox.vala (+301/-110)
src/PantheonGreeter.vala (+78/-68)
src/PantheonUser.vala (+196/-114)
src/UserList.vala (+8/-8)
src/UserListActor.vala (+6/-6)

To merge this branch:

bzr merge lp://staging/~teemperor/pantheon-greeter/fix-login

Related bugs:

Bug #1067062: pantheon-greeter still presents a password box even after disabling the password on an account	Medium	Fix Released
Bug #1305270: Checking for incorrect password takes like 4 seconds	High	Fix Released
Bug #1362827: password entry alignment in login screen	Medium	Fix Released

Link a bug report

Reviewer	Review Type	Date Requested	Status
Artem Anufrij (community)	code style		Approve on 2014-10-21
Danielle Foré	ux	2014-10-08	Approve on 2014-10-21
Review via email: mp+237689@code.staging.launchpad.net

Commit message

Added test-mode. Uses the LIghtDM-Api now correctly. Prevents that user can change credentials during authentication.

Description of the change

* Implemented busy-animation while logging in.
* Testing-mode that doesn't fuck up the system (just start the greeter normally from a session).
* Comments to some cryptic areas.
* Refactored where necessary the code.
* We are now mostly LightDM-compatible inside the code and it should be easy to implement the other auth-methods such as 2-step-verification.
* Some minor alignment issues (userlist was not vertically centered and Name/Password was not on the same x).

Revision history for this message

Raphael Isemann (teemperor) wrote on 2014-10-09:

The Tab-Behaviour is still broken, but i have no idea why.

Revision history for this message

Raphael Isemann (teemperor) wrote on 2014-10-09:

This means: Don't test for correctly working Tab. It was broken and it is still broken, but i'm out of ideas why it is broken, so it will take a while until this is fixed.

Revision history for this message

Cody Garver (codygarver) wrote on 2014-10-09:

I have no panel entries/panel at all

Revision history for this message

Raphael Isemann (teemperor) wrote on 2014-10-09:

Can you post the content of:
/var/log/lightdm/x-0-greeter.log
and
/var/log/lightdm/x-0-greeter.log.old
(you need su rights to read them).

Revision history for this message

Cody Garver (codygarver) wrote on 2014-10-09:

log: http://pastebin.com/3BntTN7Z

old log: http://pastebin.com/6L7eKwtH

On Thu, Oct 9, 2014 at 4:27 PM, Raphael Isemann <email address hidden>
wrote:

> Can you post the content of:
> /var/log/lightdm/x-0-greeter.log
> and
> /var/log/lightdm/x-0-greeter.log.old
> (you need su rights to read them).
> --
>
> https://code.launchpad.net/~teemperor/pantheon-greeter/fix-login/+merge/237689
> Your team elementary Pantheon team is requested to review the proposed
> merge of lp:~teemperor/pantheon-greeter/fix-login into lp:pantheon-greeter.
>

--
Cody Garver

lp://staging/~teemperor/pantheon-greeter/fix-login updated on 2014-10-09

294. By Raphael Isemann on 2014-10-09: More comments and better formatting for Authenticator.vala
295. By Raphael Isemann on 2014-10-09: More comments
296. By Raphael Isemann on 2014-10-09: Forgot to set awaiting_start_session

Revision history for this message

Raphael Isemann (teemperor) wrote on 2014-10-09:

Sorry, my bad, can you retry?

Revision history for this message

Cody Garver (codygarver) wrote on 2014-10-09:

Still nothing

Revision history for this message

Cody Garver (codygarver) wrote on 2014-10-20:

No indicators in my virtual machine either

Revision history for this message

Raphael Isemann (teemperor) wrote on 2014-10-20:

Wait, what's the exact problem now? The test mode (so if you just start
the binary from a session) has no indicators/panel as they change
otherwise the settings of the current session . So I disabled them there.
Can you verify that it is only in the test mode?
Am 20.10.2014 02:31 schrieb "Cody Garver" <email address hidden>:

> No indicators in my virtual machine either
> --
>
> https://code.launchpad.net/~teemperor/pantheon-greeter/fix-login/+merge/237689
> You are the owner of lp:~teemperor/pantheon-greeter/fix-login.
>

Revision history for this message

Cody Garver (codygarver) wrote on 2014-10-20:

I don't use test mode, I build using packaging and install .deb

On Mon, Oct 20, 2014 at 12:30 AM, Raphael Isemann <email address hidden>
wrote:

> Wait, what's the exact problem now? The test mode (so if you just start
> the binary from a session) has no indicators/panel as they change
> otherwise the settings of the current session . So I disabled them there.
> Can you verify that it is only in the test mode?
> Am 20.10.2014 02:31 schrieb "Cody Garver" <email address hidden>:
>
> > No indicators in my virtual machine either
> > --
> >
> >
> https://code.launchpad.net/~teemperor/pantheon-greeter/fix-login/+merge/237689
> > You are the owner of lp:~teemperor/pantheon-greeter/fix-login.
> >
>
> --
>
> https://code.launchpad.net/~teemperor/pantheon-greeter/fix-login/+merge/237689
> Your team elementary Pantheon team is requested to review the proposed
> merge of lp:~teemperor/pantheon-greeter/fix-login into lp:pantheon-greeter.
>

--
Cody Garver

lp://staging/~teemperor/pantheon-greeter/fix-login updated on 2014-10-21

297. By Raphael Isemann on 2014-10-21: Fixed that the indicators were missing
298. By Raphael Isemann on 2014-10-21: Fixed layout of the password-entry