Merge lp://staging/~teemperor/pantheon-greeter/fix-caps-lock into lp://staging/~elementary-pantheon/pantheon-greeter/trunk
| Status: | Rejected |
|---|---|
| Rejected by: | Cody Garver |
| Proposed branch: | lp://staging/~teemperor/pantheon-greeter/fix-caps-lock |
| Merge into: | lp://staging/~elementary-pantheon/pantheon-greeter/trunk |
| Diff against target: |
181 lines (+116/-9) 3 files modified
src/CredentialsArea.vala (+94/-1) src/LoginBox.vala (+1/-1) src/Utilities.vala (+21/-7) |
| To merge this branch: | bzr merge lp://staging/~teemperor/pantheon-greeter/fix-caps-lock |
| Related bugs: |
| Reviewer | Review Type | Date Requested | Status |
|---|---|---|---|
| Danielle Foré | Needs Fixing | ||
|
Review via email:
|
|||
Commit message
Implemented caps lock warning.
Description of the change
Adds a caps lock warning as a popover. The popover is not red as it was in the original mockup as this would requirea extra CSS class and there is currently no decision how we handle all those custom CSS classes that we need for the greeter.
What to test:
* Warning appears at the correct position?
* Warning appears and disappears when switching caps lock on/off
* Warning correctly handles scrolling the login options up/down with activated caps lock
* Warning correctly disappears when the user scrolls to a login option that isn't requiring keyboard input (guest login for example).
* Warning disappears when logging in
* Warning is appearing when starting the greeter with already activated caps lock.
What NOT to test:
* Warning is red? (as this can't be implemented without having a decision about the already mentioned theming infrastructure).
Unmerged revisions
- 325. By Raphael Isemann
-
No more PopOver-clones appearing when typing. PopOver is now at the correct position.
- 324. By Raphael Isemann
-
First version of the caps-lock popver. Uploading for tom
Hm the alignment is pretty weird here. I'm not sure what it's supposed to be aligning to.
The shadow is very harsh and it gets cut off at the bottom. It doesn't look like these values are coming from the theme.
The padding underneath the label is greater than the padding above. The padding to the left and right seems pretty extreme.
The warning disappears if you move the cursor over it.