Greeter

Merge lp://staging/~teemperor/pantheon-greeter/fix-1130246 into lp://staging/~elementary-pantheon/pantheon-greeter/trunk

fix-1130246
Merge into trunk

Proposed by Raphael Isemann on 2013-02-19

Status:

Superseded

Proposed branch:

lp://staging/~teemperor/pantheon-greeter/fix-1130246

Merge into:

lp://staging/~elementary-pantheon/pantheon-greeter/trunk

Diff against target:

42 lines (+16/-0)

3 files modified

CMakeLists.txt (+1/-0)
src/PantheonGreeter.vala (+3/-0)
vapi/posix-fixes.vapi (+12/-0)

To merge this branch:

bzr merge lp://staging/~teemperor/pantheon-greeter/fix-1130246

High

Fix Released

Link a bug report

Reviewer	Date Requested	Status
Sergey "Shnatsel" Davidoff (community)		Abstain on 2013-07-03
Cody Garver (community)	2013-02-19	Needs Fixing on 2013-03-11
Review via email: mp+149356@code.staging.launchpad.net

This proposal has been superseded by a proposal from 2013-07-04.

Description of the change

The posix-fixes.vapi is needed because the mlockall isn't included in the system-vapi.
Kudos to the unity-greeter devs at canonical for the good tipps.

lp://staging/~teemperor/pantheon-greeter/fix-1130246 updated on 2013-03-09

151. By Launchpad Translations on behalf of elementary-pantheon on 2013-02-20: Launchpad automatic translations update.
152. By Launchpad Translations on behalf of elementary-pantheon on 2013-02-21: Launchpad automatic translations update.
153. By Launchpad Translations on behalf of elementary-pantheon on 2013-02-22: Launchpad automatic translations update.
154. By Launchpad Translations on behalf of elementary-pantheon on 2013-02-24: Launchpad automatic translations update.
155. By Launchpad Translations on behalf of elementary-pantheon on 2013-02-26: Launchpad automatic translations update.
156. By Launchpad Translations on behalf of elementary-pantheon on 2013-02-27: Launchpad automatic translations update.
157. By Raphael Isemann on 2013-02-28: Resize textures before sending to GPU to save memory and prevent segfaults on some drivers to fix bug #1065086.
158. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-01: Launchpad automatic translations update.
159. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-05: Launchpad automatic translations update.
160. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-06: Launchpad automatic translations update.
161. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-09: Launchpad automatic translations update.
162. By Rico Tzschichholz on 2013-03-09: build: explictly link against libm

Revision history for this message

Cody Garver (codygarver) wrote on 2013-03-11:

Merge issue:

+N vapi/posix-fixes.vapi
M CMakeLists.txt
M src/PantheonGreeter.vala
Text conflict in CMakeLists.txt
1 conflicts encountered.

review: Needs Fixing

lp://staging/~teemperor/pantheon-greeter/fix-1130246 updated on 2013-04-14

163. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-12: Launchpad automatic translations update.
164. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-14: Launchpad automatic translations update.
165. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-17: Launchpad automatic translations update.
166. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-18: Launchpad automatic translations update.
167. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-25: Launchpad automatic translations update.
168. By Cody Garver on 2013-03-27: Add 'make dist' command for creating release tarball to fix bug #1076823. Approved by David Gomes.
169. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-30: Launchpad automatic translations update.
170. By Launchpad Translations on behalf of elementary-pantheon on 2013-03-31: Launchpad automatic translations update.
171. By Launchpad Translations on behalf of elementary-pantheon on 2013-04-07: Launchpad automatic translations update.
172. By Corentin Noël on 2013-04-10: Remember user's preference for Num Lock on/off to fix bug #1166955. This is a courtesy for certain laptop keyboards.
173. By Launchpad Translations on behalf of elementary-pantheon on 2013-04-11: Launchpad automatic translations update.
174. By Launchpad Translations on behalf of elementary-pantheon on 2013-04-13: Launchpad automatic translations update.
175. By Launchpad Translations on behalf of elementary-pantheon on 2013-04-14: Launchpad automatic translations update.

Revision history for this message

Cody Garver (codygarver) wrote on 2013-04-17:

WIP, waiting on shnatsel collaboration with teemperor.

lp://staging/~teemperor/pantheon-greeter/fix-1130246 updated on 2013-06-03

176. By Launchpad Translations on behalf of elementary-pantheon on 2013-04-19: Launchpad automatic translations update.
177. By Corentin Noël on 2013-04-21: Turn Num Lock OFF by default.
178. By Launchpad Translations on behalf of elementary-pantheon on 2013-04-29: Launchpad automatic translations update.
179. By Cody Garver on 2013-04-30: CMake: require lightdm version 1.2.1 to fix bug #1059433.
180. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-07: Launchpad automatic translations update.
181. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-09: Launchpad automatic translations update.
182. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-10: Launchpad automatic translations update.
183. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-11: Launchpad automatic translations update.
184. By Raphael Isemann on 2013-05-13: Change wallpaper interpolation to bilinear to fix bug #1167855.
185. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-21: Launchpad automatic translations update.
186. By Raphael Isemann on 2013-05-21: Show the default-wallpaper on loading errors. This should help against the black-screen on encrypted disks to fix bug #1128051.
187. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-22: Launchpad automatic translations update.
188. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-23: Launchpad automatic translations update.
189. By Launchpad Translations on behalf of elementary-pantheon on 2013-05-25: Launchpad automatic translations update.
190. By Raphael Isemann on 2013-06-02: Expanded a translation message for the AM/PM string
191. By Cody Garver on 2013-06-02: Updated translation template.
192. By Launchpad Translations on behalf of elementary-pantheon on 2013-06-03: Launchpad automatic translations update.

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2013-06-09:

I don't think you need a new VAPI for this, Rico showed me a much simpler way to do that. For example, here's how I added fchmod which was missing from POSIX VAPI: http://bazaar.launchpad.net/~shnatsel/elementaryos/bluetooth-tryexecd-vala/view/head:/bluetooth-tryexecd.vala#L31

Btw, make sure you upstream your VAPI changes. Talking to Rico about it might be a good starting point.

review: Needs Fixing

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2013-06-09:

Other than that, looks good to me.

lp://staging/~teemperor/pantheon-greeter/fix-1130246 updated on 2013-07-03

193. By Raphael Isemann on 2013-06-12: Onboard now appears correctly to fix bug #1045643.
194. By Cody Garver on 2013-06-12: [CMake] Version 1.0
195. By Launchpad Translations on behalf of elementary-pantheon on 2013-06-12: Launchpad automatic translations update.
196. By Launchpad Translations on behalf of elementary-pantheon on 2013-06-13: Launchpad automatic translations update.
197. By Tom Beckmann on 2013-06-16: This should fix the focus issue with the onboard keyboard. It also makes the previous focus stuff unnecessary.
198. By Launchpad Translations on behalf of elementary-pantheon on 2013-06-20: Launchpad automatic translations update.
199. By Cody Garver on 2013-06-20: [CMake] Version 1.0.1
200. By Launchpad Translations on behalf of elementary-pantheon on 2013-06-21: Launchpad automatic translations update.
201. By Launchpad Translations on behalf of elementary-pantheon on 2013-06-23: Launchpad automatic translations update.
202. By Launchpad Translations on behalf of elementary-pantheon on 2013-07-03: Launchpad automatic translations update.

Revision history for this message

Sergey "Shnatsel" Davidoff (shnatsel) wrote on 2013-07-03:

<ricotz> shnatsel, teemperor, better use a vapi if you need that much bindings

So, disregard my complaints. Still,

<ricotz> teemperor, better put it in an more private namespace (not Posix) to avoid clashes with future vala versions if you like to get the upstreamed

review: Abstain

lp://staging/~teemperor/pantheon-greeter/fix-1130246 updated on 2013-07-04

203. By Launchpad Translations on behalf of elementary-pantheon on 2013-07-04: Launchpad automatic translations update.
204. By Raphael Isemann on 2013-07-04: calling mlockall to prevent swapping of security-related data